Changeset 102690 in webkit

Timestamp:

Dec 13, 2011 10:34:11 AM (12 years ago)

Author:

robert@webkit.org

Message:

CSS 2.1 failure: eof-002.htm fails
​https://bugs.webkit.org/show_bug.cgi?id=74309

Reviewed by Dean Jackson.

Source/WebCore:

Test: css2.1/20110323/eof-002-expected.html

• css/CSSGrammar.y: Treat EOF during a function expression with an open parenthesis as a close parenthesis.

LayoutTests:

• css2.1/20110323/eof-002-expected.html: Added.
• css2.1/20110323/eof-002.htm: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/css2.1/20110323/eof-002-expected.html (added)
• LayoutTests/css2.1/20110323/eof-002.htm (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSGrammar.y (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-12-12  Robert Hogan  <robert@webkit.org>
+
+        CSS 2.1 failure: eof-002.htm fails
+        https://bugs.webkit.org/show_bug.cgi?id=74309
+
+        Reviewed by Dean Jackson.
+
+        * css2.1/20110323/eof-002-expected.html: Added.
+        * css2.1/20110323/eof-002.htm: Added.
+
 2011-12-13  Mike Reed  <reed@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-12  Robert Hogan  <robert@webkit.org>
+
+        CSS 2.1 failure: eof-002.htm fails
+        https://bugs.webkit.org/show_bug.cgi?id=74309
+
+        Reviewed by Dean Jackson.
+
+        Test: css2.1/20110323/eof-002-expected.html
+
+        * css/CSSGrammar.y: Treat EOF during a function expression with an open parenthesis as a close parenthesis.
+
 2011-12-13  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/css/CSSGrammar.y

@@ -1485 +1485 @@
         $$.function = f;
     } |
+    FUNCTION maybe_space expr TOKEN_EOF {
+        CSSParser* p = static_cast<CSSParser*>(parser);
+        CSSParserFunction* f = p->createFloatingFunction();
+        f->name = $1;
+        f->args = adoptPtr(p->sinkFloatingValueList($3));
+        $$.id = 0;
+        $$.unit = CSSParserValue::Function;
+        $$.function = f;
+    } |
     FUNCTION maybe_space ')' maybe_space {
         CSSParser* p = static_cast<CSSParser*>(parser);