Changeset 102757 in webkit

Timestamp:

Dec 14, 2011 2:06:20 AM (12 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: TreeOutline's is broken when li elements have padding-left different from 14px.
​https://bugs.webkit.org/show_bug.cgi?id=74445

Reviewed by Pavel Feldman.

• inspector/front-end/treeoutline.js:

(TreeElement.prototype.isEventWithinDisclosureTriangle):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/treeoutline.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-13  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: TreeOutline's is broken when li elements have padding-left different from 14px.
+        https://bugs.webkit.org/show_bug.cgi?id=74445
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/treeoutline.js:
+        (TreeElement.prototype.isEventWithinDisclosureTriangle):
+
 2011-12-13  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/treeoutline.js

@@ -952 +952 @@
 TreeElement.prototype.isEventWithinDisclosureTriangle = function(event)
 {
-    const leftPadding = 14;
-    var left = this._listItemNode.totalOffsetLeft() + leftPadding;
+    // FIXME: We should not use getComputedStyle(). For that we need to get rid of using ::before for disclosure triangle. (http://webk.it/74446) 
+    var computedLeftPadding = window.getComputedStyle(this._listItemNode).getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX);
+    var left = this._listItemNode.totalOffsetLeft() + computedLeftPadding;
     return event.pageX >= left && event.pageX <= left + this.arrowToggleWidth && this.hasChildren;
 }