Changeset 102767 in webkit
- Timestamp:
- Dec 14, 2011 5:00:21 AM (12 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r102766 r102767 1 2011-12-14 Rakesh KN <rakesh.kn@motorola.com> 2 3 [Non-Mac] Change event should be fired when changing option by using keyboard. 4 https://bugs.webkit.org/show_bug.cgi?id=74384 5 6 Reviewed by Kent Tamura. 7 8 Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys. 9 10 * fast/forms/select/menulist-onchange-fired-with-key-up-down-expected.txt: Added. 11 * fast/forms/select/menulist-onchange-fired-with-key-up-down.html: Added. 12 * platform/chromium/test_expectations.txt: 13 Skipped for Chromium MAC. 14 * platform/mac/Skipped: 15 Skipped for Apple MAC. 16 1 17 2011-12-14 João Paulo Rechi Vita <jprvita@openbossa.org> 2 18 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r102741 r102767 3992 3992 3993 3993 BUGWK74374 WIN : fast/forms/select-listbox-multiple-no-focusring.html = PASS IMAGE 3994 3995 BUGWK74384 MAC SKIP : fast/forms/select/menulist-onchange-fired-with-key-up-down.html = FAIL -
trunk/LayoutTests/platform/mac/Skipped
r102510 r102767 515 515 # https://bugs.webkit.org/show_bug.cgi?id=73974 516 516 fast/canvas/webgl/canvas-2d-webgl-texture.html 517 518 # https://bugs.webkit.org/show_bug.cgi?id=74384 519 # Skipped as this is not a expected behaviour on mac. 520 fast/forms/select/menulist-onchange-fired-with-key-up-down.html -
trunk/Source/WebCore/ChangeLog
r102757 r102767 1 2011-12-14 Rakesh KN <rakesh.kn@motorola.com> 2 3 [Non-Mac] Change event should be fired when changing option by using keyboard. 4 https://bugs.webkit.org/show_bug.cgi?id=74384 5 6 Reviewed by Kent Tamura. 7 8 Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys. 9 10 Test: fast/forms/select/menulist-onchange-fired-with-key-up-down.html 11 12 * html/HTMLSelectElement.cpp: 13 (WebCore::HTMLSelectElement::menuListDefaultEventHandler): 14 Setting the DispatchChangeEvent selection option flag when the option is selected using 15 up/down/right/left/pageup/pagedown/home/end keys. 16 1 17 2011-12-13 Vsevolod Vlasov <vsevik@chromium.org> 2 18 -
trunk/Source/WebCore/html/HTMLSelectElement.cpp
r102741 r102767 1051 1051 1052 1052 if (handled && static_cast<size_t>(listIndex) < listItems.size()) 1053 selectOption(listToOptionIndex(listIndex), DeselectOtherOptions | UserDriven);1053 selectOption(listToOptionIndex(listIndex), DeselectOtherOptions | DispatchChangeEvent | UserDriven); 1054 1054 1055 1055 if (handled)
Note: See TracChangeset
for help on using the changeset viewer.