Changeset 103073 in webkit


Ignore:
Timestamp:
Dec 16, 2011 8:57:31 AM (12 years ago)
Author:
mnaganov@chromium.org
Message:

Scroll non-visible edit controls and caret into the center of the view when starting typing.
​https://bugs.webkit.org/show_bug.cgi?id=65027

Reviewed by Ryosuke Niwa.

Tests: editing/input/caret-at-the-edge-of-contenteditable.html

editing/input/caret-at-the-edge-of-input.html
editing/input/reveal-caret-of-multiline-contenteditable.html
editing/input/reveal-caret-of-multiline-input.html
editing/input/reveal-contenteditable-on-input-vertically.html
editing/input/reveal-contenteditable-on-paste-vertically.html
editing/input/reveal-edit-on-input-vertically.html
editing/input/reveal-edit-on-paste-vertically.html

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):

  • editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
  • editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
  • editing/input/caret-at-the-edge-of-contenteditable.html: Added.
  • editing/input/caret-at-the-edge-of-input-expected.png: Added.
  • editing/input/caret-at-the-edge-of-input-expected.txt: Added.
  • editing/input/caret-at-the-edge-of-input.html: Added.
  • editing/input/resources/reveal-utilities.js: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
  • editing/input/reveal-caret-of-multiline-contenteditable.html: Added.
  • editing/input/reveal-caret-of-multiline-input-expected.png: Added.
  • editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
  • editing/input/reveal-caret-of-multiline-input.html: Added.
  • editing/input/reveal-contenteditable-on-input-vertically-expected.txt: Added.
  • editing/input/reveal-contenteditable-on-input-vertically.html: Added.
  • editing/input/reveal-contenteditable-on-paste-vertically-expected.txt: Added.
  • editing/input/reveal-contenteditable-on-paste-vertically.html: Added.
  • editing/input/reveal-edit-on-input-vertically-expected.txt: Added.
  • editing/input/reveal-edit-on-input-vertically.html: Added.
  • editing/input/reveal-edit-on-paste-vertically-expected.txt: Added.
  • editing/input/reveal-edit-on-paste-vertically.html: Added.
  • platform/chromium/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/gtk/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/qt/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
  • platform/win/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
Location:
trunk
Files:
21 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r103071 r103073  
     12011-12-16  Mikhail Naganov  <mnaganov@chromium.org>
     2
     3        Scroll non-visible edit controls and caret into the center of the view when starting typing.
     4        https://bugs.webkit.org/show_bug.cgi?id=65027
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
     9        * editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
     10        * editing/input/caret-at-the-edge-of-contenteditable.html: Added.
     11        * editing/input/caret-at-the-edge-of-input-expected.png: Added.
     12        * editing/input/caret-at-the-edge-of-input-expected.txt: Added.
     13        * editing/input/caret-at-the-edge-of-input.html: Added.
     14        * editing/input/resources/reveal-utilities.js: Added.
     15        * editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
     16        * editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
     17        * editing/input/reveal-caret-of-multiline-contenteditable.html: Added.
     18        * editing/input/reveal-caret-of-multiline-input-expected.png: Added.
     19        * editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
     20        * editing/input/reveal-caret-of-multiline-input.html: Added.
     21        * editing/input/reveal-contenteditable-on-input-vertically-expected.txt: Added.
     22        * editing/input/reveal-contenteditable-on-input-vertically.html: Added.
     23        * editing/input/reveal-contenteditable-on-paste-vertically-expected.txt: Added.
     24        * editing/input/reveal-contenteditable-on-paste-vertically.html: Added.
     25        * editing/input/reveal-edit-on-input-vertically-expected.txt: Added.
     26        * editing/input/reveal-edit-on-input-vertically.html: Added.
     27        * editing/input/reveal-edit-on-paste-vertically-expected.txt: Added.
     28        * editing/input/reveal-edit-on-paste-vertically.html: Added.
     29        * platform/chromium/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
     30        * platform/gtk/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
     31        * platform/qt/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
     32        * platform/win/test_expectations.txt: Mark new tests as FAIL to grab results from bots.
     33
    1342011-12-15  Philippe Normand  <pnormand@igalia.com>
    235

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r103057 r103073  
    40184018
    40194019BUGWK74688  : fast/css/bidi-override-in-anonymous-block.html = TEXT
     4020
     4021// Landing new tests, need to grab results from bots.
     4022BUGMNAGANOV : editing/input/caret-at-the-edge-of-contenteditable.html = FAIL
     4023BUGMNAGANOV : editing/input/caret-at-the-edge-of-input.html = FAIL
     4024BUGMNAGANOV : editing/input/reveal-caret-of-multiline-contenteditable.html = FAIL
     4025BUGMNAGANOV : editing/input/reveal-caret-of-multiline-input.html = FAIL
     4026BUGMNAGANOV : editing/input/reveal-contenteditable-on-input-vertically.html = FAIL
     4027BUGMNAGANOV : editing/input/reveal-contenteditable-on-paste-vertically.html = FAIL
     4028BUGMNAGANOV : editing/input/reveal-edit-on-input-vertically.html = FAIL
     4029BUGMNAGANOV : editing/input/reveal-edit-on-paste-vertically.html = FAIL

  • trunk/LayoutTests/platform/gtk/test_expectations.txt

    r103064 r103073  
    9898
    9999BUGWK74270 : fast/forms/basic-selects.html = FAIL
     100
     101// Landing new tests, need to grab results from bots.
     102BUGMNAGANOV : editing/input/caret-at-the-edge-of-contenteditable.html = FAIL
     103BUGMNAGANOV : editing/input/caret-at-the-edge-of-input.html = FAIL
     104BUGMNAGANOV : editing/input/reveal-caret-of-multiline-contenteditable.html = FAIL
     105BUGMNAGANOV : editing/input/reveal-caret-of-multiline-input.html = FAIL
     106BUGMNAGANOV : editing/input/reveal-contenteditable-on-input-vertically.html = FAIL
     107BUGMNAGANOV : editing/input/reveal-contenteditable-on-paste-vertically.html = FAIL
     108BUGMNAGANOV : editing/input/reveal-edit-on-input-vertically.html = FAIL
     109BUGMNAGANOV : editing/input/reveal-edit-on-paste-vertically.html = FAIL

  • trunk/LayoutTests/platform/qt/test_expectations.txt

    r102787 r103073  
    2525// The test hits an ASSERT in Debug.
    2626BUGWK68859 DEBUG : fast/dynamic/crash-paint-no-documentElement-renderer.html = CRASH
     27
     28// Landing new tests, need to grab results from bots.
     29BUGMNAGANOV : editing/input/caret-at-the-edge-of-contenteditable.html = FAIL
     30BUGMNAGANOV : editing/input/caret-at-the-edge-of-input.html = FAIL
     31BUGMNAGANOV : editing/input/reveal-caret-of-multiline-contenteditable.html = FAIL
     32BUGMNAGANOV : editing/input/reveal-caret-of-multiline-input.html = FAIL
     33BUGMNAGANOV : editing/input/reveal-contenteditable-on-input-vertically.html = FAIL
     34BUGMNAGANOV : editing/input/reveal-contenteditable-on-paste-vertically.html = FAIL
     35BUGMNAGANOV : editing/input/reveal-edit-on-input-vertically.html = FAIL
     36BUGMNAGANOV : editing/input/reveal-edit-on-paste-vertically.html = FAIL

  • trunk/LayoutTests/platform/win/test_expectations.txt

    r102787 r103073  
    2020// The test hits an ASSERT in Debug.
    2121BUGWK68859 DEBUG : fast/dynamic/crash-paint-no-documentElement-renderer.html = CRASH
     22
     23// Landing new tests, need to grab results from bots.
     24BUGMNAGANOV : editing/input/caret-at-the-edge-of-contenteditable.html = FAIL
     25BUGMNAGANOV : editing/input/caret-at-the-edge-of-input.html = FAIL
     26BUGMNAGANOV : editing/input/reveal-caret-of-multiline-contenteditable.html = FAIL
     27BUGMNAGANOV : editing/input/reveal-caret-of-multiline-input.html = FAIL
     28BUGMNAGANOV : editing/input/reveal-contenteditable-on-input-vertically.html = FAIL
     29BUGMNAGANOV : editing/input/reveal-contenteditable-on-paste-vertically.html = FAIL
     30BUGMNAGANOV : editing/input/reveal-edit-on-input-vertically.html = FAIL
     31BUGMNAGANOV : editing/input/reveal-edit-on-paste-vertically.html = FAIL

  • trunk/Source/WebCore/ChangeLog

    r103072 r103073  
     12011-12-16  Mikhail Naganov  <mnaganov@chromium.org>
     2
     3        Scroll non-visible edit controls and caret into the center of the view when starting typing.
     4        https://bugs.webkit.org/show_bug.cgi?id=65027
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Tests: editing/input/caret-at-the-edge-of-contenteditable.html
     9               editing/input/caret-at-the-edge-of-input.html
     10               editing/input/reveal-caret-of-multiline-contenteditable.html
     11               editing/input/reveal-caret-of-multiline-input.html
     12               editing/input/reveal-contenteditable-on-input-vertically.html
     13               editing/input/reveal-contenteditable-on-paste-vertically.html
     14               editing/input/reveal-edit-on-input-vertically.html
     15               editing/input/reveal-edit-on-paste-vertically.html
     16
     17        * editing/Editor.cpp:
     18        (WebCore::Editor::insertTextWithoutSendingTextEvent):
     19        (WebCore::Editor::revealSelectionAfterEditingOperation):
     20
    1212011-12-16  Ryosuke Niwa  <rniwa@webkit.org>
    222

  • trunk/Source/WebCore/editing/Editor.cpp

    r102955 r103073  
    10061006            if (Frame* editedFrame = document->frame())
    10071007                if (Page* page = editedFrame->page())
    1008                     page->focusController()->focusedOrMainFrame()->selection()->revealSelection(ScrollAlignment::alignToEdgeIfNeeded);
     1008                    page->focusController()->focusedOrMainFrame()->selection()->revealSelection(ScrollAlignment::alignCenterIfNeeded);
    10091009        }
    10101010    }
    … …  
    23402340        return;
    23412341
    2342     m_frame->selection()->revealSelection(ScrollAlignment::alignToEdgeIfNeeded);
     2342    m_frame->selection()->revealSelection(ScrollAlignment::alignCenterIfNeeded);
    23432343}
    23442344
Note: See TracChangeset for help on using the changeset viewer.