Changeset 103545 in webkit

Timestamp:

Dec 22, 2011 8:32:03 AM (12 years ago)

Author:

ddkilzer@apple.com

Message:

run-api-tests: dumpAllTests() should not use global variables

Reviewed by Adam Roben.

Part of: <​http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

• Scripts/run-api-tests: Renamed $dump to $dumpTests.

(dumpTestsBySuite): Rename from dumpAllTests() and pass in
global data as an argument. Sort suite names and test names
alphabetically to match output when running tests.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-api-tests (modified) (5 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-12-22  David Kilzer  <ddkilzer@apple.com>
+
+        run-api-tests: dumpAllTests() should not use global variables
+
+        Reviewed by Adam Roben.
+
+        Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
+
+        * Scripts/run-api-tests: Renamed $dump to $dumpTests.
+        (dumpTestsBySuite): Rename from dumpAllTests() and pass in
+        global data as an argument.  Sort suite names and test names
+        alphabetically to match output when running tests.
+
 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
 

trunk/Tools/Scripts/run-api-tests

@@ -40 +40 @@
 
 sub buildTestTool();
-sub dumpAllTests();
+sub dumpTestsBySuite(\%);
 sub populateTests();
 sub runAllTests();
@@ -56 +56 @@
 my $showHelp = 0;
 my $verbose = 0;
-my $dump = 0;
+my $dumpTests = 0;
 my $build = 1;
 my $buildDefault = $build ? "build" : "do not build";
@@ -75 +75 @@
     'help' => \$showHelp,
     'verbose|v' => \$verbose,
-    'dump|d' => \$dump,
+    'dump|d' => \$dumpTests,
     'build!' => \$build
 );
@@ -89 +89 @@
 my %testsToRun = populateTests();
 
-if ($dump) {
-    dumpAllTests();
+if ($dumpTests) {
+    dumpTestsBySuite(%testsToRun);
     exit 0;
 }
@@ -103 +103 @@
 }
 
-sub dumpAllTests()
-{
+sub dumpTestsBySuite(\%)
+{
+    my ($testsBySuite) = @_;
     print "Dumping test cases\n";
     print "------------------\n";
-    for my $suite (keys %testsToRun) {
+    for my $suite (sort keys %$testsBySuite) {
         print $suite . ":\n";
-        print map { "   " . $_ . "\n" } @{ $testsToRun{$suite} };
+        print map { "   " . $_ . "\n" } sort @{ $testsBySuite->{$suite} };
     }
     print "------------------\n";