Changeset 103549 in webkit

Timestamp:

Dec 22, 2011 9:19:49 AM (12 years ago)

Author:

ddkilzer@apple.com

Message:

run-api-tests: inline runAllTestsInSuite() into runAllTests()

Reviewed by Adam Roben.

Part of: <​http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

In order to make it easy to run one or more individual suites,
or one more individual tests, it's easier to call a single
method with different data structures than individual methods.

• Scripts/run-api-tests:

(runAllTests): Inline runAllTestsInSuite().

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-api-tests (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-12-22  David Kilzer  <ddkilzer@apple.com>
+
+        run-api-tests: inline runAllTestsInSuite() into runAllTests()
+
+        Reviewed by Adam Roben.
+
+        Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
+
+        In order to make it easy to run one or more individual suites,
+        or one more individual tests, it's easier to call a single
+        method with different data structures than individual methods.
+
+        * Scripts/run-api-tests:
+        (runAllTests): Inline runAllTestsInSuite().
+
 2011-12-22  Adam Roben  <aroben@apple.com>
 

trunk/Tools/Scripts/run-api-tests

@@ -43 +43 @@
 sub populateTests();
 sub runAllTests();
-sub runAllTestsInSuite($);
 sub runTest($$);
 sub prepareEnvironmentForRunningTestTool();
@@ -119 +118 @@
     my $anyFailures = 0;
     for my $suite (sort keys %testsToRun) {
-        my $failed = runAllTestsInSuite($suite);
-        if ($failed) {
-            $anyFailures = 1;
+        print "Suite: $suite\n" unless $verbose;
+        for my $test (sort @{$testsToRun{$suite}}) {
+            my $failed = runTest($suite, $test);
+            if ($failed) {
+                $anyFailures = 1;
+            }
         }
     }
@@ -139 +141 @@
         }
     }
-    return $anyFailures;
-}
-
-sub runAllTestsInSuite($)
-{
-    my ($suite) = @_;
-    print "Suite: $suite\n" unless $verbose;
-
-    my $anyFailures = 0;
-    for my $test (sort @{$testsToRun{$suite}}) {
-        my $failed = runTest($suite, $test);
-        if ($failed) {
-            $anyFailures = 1;
-        }
-    }
-   
     return $anyFailures;
 }