Changeset 103551 in webkit

Timestamp:

Dec 22, 2011 9:29:24 AM (12 years ago)

Author:

ddkilzer@apple.com

Message:

run-api-tests: runAllTests() and runTest() should not use global variables

Reviewed by Adam Roben.

Part of: <​http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests

• Scripts/run-api-tests:

(runTestsBySuite): Rename from runAllTests(). Add arguments for
list of tests and $verbose.
(runTest): Add $verbose argument.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-api-tests (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-12-22  David Kilzer  <ddkilzer@apple.com>
+
+        run-api-tests: runAllTests() and runTest() should not use global variables
+
+        Reviewed by Adam Roben.
+
+        Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
+
+        * Scripts/run-api-tests:
+        (runTestsBySuite): Rename from runAllTests().  Add arguments for
+        list of tests and $verbose.
+        (runTest): Add $verbose argument.
+
 2011-12-22  David Kilzer  <ddkilzer@apple.com>
 

trunk/Tools/Scripts/run-api-tests

@@ -42 +42 @@
 sub dumpTestsBySuite(\%);
 sub populateTests();
-sub runAllTests();
-sub runTest($$);
+sub runTest($$$);
+sub runTestsBySuite(\%$);
 sub prepareEnvironmentForRunningTestTool();
 sub testToolPath();
@@ -93 +93 @@
 }
 
-if (runAllTests()) {
+if (runTestsBySuite(%testsToRun, $verbose)) {
     exit 1;
 }
@@ -114 +114 @@
 }
 
-sub runAllTests()
-{
+sub runTestsBySuite(\%$)
+{
+    my ($tests, $verbose) = @_;
     my $anyFailures = 0;
-    for my $suite (sort keys %testsToRun) {
+    for my $suite (sort keys %$tests) {
         print "Suite: $suite\n" unless $verbose;
-        for my $test (sort @{$testsToRun{$suite}}) {
-            my $failed = runTest($suite, $test);
+        for my $test (sort @{$tests->{$suite}}) {
+            my $failed = runTest($suite, $test, $verbose);
             if ($failed) {
                 $anyFailures = 1;
@@ -144 +145 @@
 }
 
-sub runTest($$)
-{
-    my ($suite, $testName) = @_;
+sub runTest($$$)
+{
+    my ($suite, $testName, $verbose) = @_;
     my $test = $suite . "." . $testName;