Changeset 103701 in webkit

Timestamp:

Dec 26, 2011 11:12:57 PM (12 years ago)

Author:

morrita@google.com

Message:

[Refactoring] Node::setTreeScopeRecursively() doesn't need includeRoot parameter
​https://bugs.webkit.org/show_bug.cgi?id=75240

Reviewed by Anders Carlsson.

No new tests. No behavior change.

• dom/Node.cpp:

(WebCore::Node::setTreeScopeRecursively):

• dom/Node.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Node.cpp (modified) (2 diffs)
• dom/Node.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-26  Hajime Morrita  <morrita@chromium.org>
+
+        [Refactoring] Node::setTreeScopeRecursively() doesn't need includeRoot parameter
+        https://bugs.webkit.org/show_bug.cgi?id=75240
+
+        Reviewed by Anders Carlsson.
+
+        No new tests. No behavior change.
+
+        * dom/Node.cpp:
+        (WebCore::Node::setTreeScopeRecursively):
+        * dom/Node.h:
+
 2011-12-26  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/dom/Node.cpp

@@ -460 +460 @@
 }
 
-void Node::setTreeScopeRecursively(TreeScope* newTreeScope, bool includeRoot)
+void Node::setTreeScopeRecursively(TreeScope* newTreeScope)
 {
     ASSERT(this);
-    ASSERT(!includeRoot || !isDocumentNode());
+    ASSERT(!isDocumentNode());
     ASSERT(newTreeScope);
     ASSERT(!m_deletionHasBegun);
@@ -480 +480 @@
         currentDocument->incDOMTreeVersion();
 
-    for (Node* node = includeRoot ? this : traverseNextNode(this); node; node = node->traverseNextNode(this)) {
+    for (Node* node = this; node; node = node->traverseNextNode(this)) {
         if (newTreeScope == newDocument) {
             if (node->hasRareData())

trunk/Source/WebCore/dom/Node.h

@@ -385 +385 @@
 
     // Used by the basic DOM methods (e.g., appendChild()).
-    void setTreeScopeRecursively(TreeScope*, bool includeRoot = true);
+    void setTreeScopeRecursively(TreeScope*);
 
     // Returns true if this node is associated with a document and is in its associated document's