Changeset 103751 in webkit


Ignore:
Timestamp:
Dec 27, 2011 6:47:37 PM (12 years ago)
Author:
dominicc@chromium.org
Message:

Remove initWebKitAnimationEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71698

Reviewed by Ojan Vafai.

Source/WebCore:

Now that WebKitAnimationEvent has a constructor, we don't need
this
method. <​https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> is
tracking the change to the CSS Animations spec.

  • dom/WebKitAnimationEvent.cpp:
  • dom/WebKitAnimationEvent.h:
  • dom/WebKitAnimationEvent.idl:

LayoutTests:

  • fast/events/init-events-expected.txt:
  • fast/events/script-tests/init-events.js:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r103750 r103751  
     12011-12-27  Dominic Cooney   <dominicc@chromium.org>
     2
     3        Remove initWebKitAnimationEvent method
     4        https://bugs.webkit.org/show_bug.cgi?id=71698
     5
     6        Reviewed by Ojan Vafai.
     7
     8        * fast/events/init-events-expected.txt:
     9        * fast/events/script-tests/init-events.js:
     10
    1112011-12-27  Ryosuke Niwa  <rniwa@webkit.org>
    212

  • trunk/LayoutTests/fast/events/init-events-expected.txt

    r103746 r103751  
    165165PASS testInitEvent('UI', '"a", false, false, window, 1001').pageY is 0
    166166PASS testInitEvent('UI', '"a", false, false, window, 1001').which is 0
    167 PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').type is 'a'
    168 PASS testInitEvent('WebKitAnimation', 'null, false, false, "b", 1001').type is 'null'
    169 PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').bubbles is false
    170 PASS testInitEvent('WebKitAnimation', '"a", true, false, "b", 1001').bubbles is true
    171 PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').cancelable is false
    172 PASS testInitEvent('WebKitAnimation', '"a", false, true, "b", 1001').cancelable is true
    173 PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').animationName is 'b'
    174 PASS testInitEvent('WebKitAnimation', '"a", false, false, null, 1001').animationName is 'null'
    175 PASS testInitEvent('WebKitAnimation', '"a", false, false, "b", 1001').elapsedTime is 1001
    176167PASS successfullyParsed is true
    177168

  • trunk/LayoutTests/fast/events/script-tests/init-events.js

    r103746 r103751  
    182182shouldBe("testInitEvent('UI', '\"a\", false, false, window, 1001').which", "0");
    183183
    184 shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').type", "'a'");
    185 shouldBe("testInitEvent('WebKitAnimation', 'null, false, false, \"b\", 1001').type", "'null'");
    186 shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').bubbles", "false");
    187 shouldBe("testInitEvent('WebKitAnimation', '\"a\", true, false, \"b\", 1001').bubbles", "true");
    188 shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').cancelable", "false");
    189 shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, true, \"b\", 1001').cancelable", "true");
    190 shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').animationName", "'b'");
    191 shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, null, 1001').animationName", "'null'");
    192 shouldBe("testInitEvent('WebKitAnimation', '\"a\", false, false, \"b\", 1001').elapsedTime", "1001");
    193 
    194184// WheelEvent has no init function yet; roughly speaking, we are waiting for that part of DOM 3 to stabilize.

  • trunk/Source/WebCore/ChangeLog

    r103746 r103751  
     12011-12-27  Dominic Cooney  <dominicc@chromium.org>
     2
     3        Remove initWebKitAnimationEvent method
     4        https://bugs.webkit.org/show_bug.cgi?id=71698
     5
     6        Reviewed by Ojan Vafai.
     7
     8        Now that WebKitAnimationEvent has a constructor, we don't need
     9        this
     10        method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> is
     11        tracking the change to the CSS Animations spec.
     12
     13        * dom/WebKitAnimationEvent.cpp:
     14        * dom/WebKitAnimationEvent.h:
     15        * dom/WebKitAnimationEvent.idl:
     16
    1172011-12-27  Dominic Cooney   <dominicc@chromium.org>
    218

  • trunk/Source/WebCore/dom/WebKitAnimationEvent.cpp

    r98044 r103751  
    6060}
    6161
    62 void WebKitAnimationEvent::initWebKitAnimationEvent(const AtomicString& type,
    63                                         bool canBubbleArg,
    64                                         bool cancelableArg,
    65                                         const String& animationName,
    66                                         double elapsedTime)
    67 {
    68     if (dispatched())
    69         return;
    70    
    71     initEvent(type, canBubbleArg, cancelableArg);
    72    
    73     m_animationName = animationName;
    74     m_elapsedTime = elapsedTime;
    75 }
    76 
    7762const String& WebKitAnimationEvent::animationName() const
    7863{

  • trunk/Source/WebCore/dom/WebKitAnimationEvent.h

    r98044 r103751  
    5555    virtual ~WebKitAnimationEvent();
    5656
    57     void initWebKitAnimationEvent(const AtomicString& type,
    58                                   bool canBubbleArg,
    59                                   bool cancelableArg,
    60                                   const String& animationName,
    61                                   double elapsedTime);
    62 
    6357    const String& animationName() const;
    6458    double elapsedTime() const;

  • trunk/Source/WebCore/dom/WebKitAnimationEvent.idl

    r100564 r103751  
    3131        readonly attribute [InitializedByConstructor] DOMString animationName;
    3232        readonly attribute [InitializedByConstructor] double elapsedTime;
    33 
    34         void initWebKitAnimationEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
    35                                       in [Optional=CallWithDefaultValue] boolean canBubbleArg,
    36                                       in [Optional=CallWithDefaultValue] boolean cancelableArg,
    37                                       in [Optional=CallWithDefaultValue] DOMString animationNameArg,
    38                                       in [Optional=CallWithDefaultValue] double elapsedTimeArg);
    3933};
    4034
Note: See TracChangeset for help on using the changeset viewer.