Changeset 103950 in webkit

Timestamp:

Jan 3, 2012 11:33:09 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform
​https://bugs.webkit.org/show_bug.cgi?id=75227

Patch by Florin Malita <​fmalita@google.com> on 2012-01-03
Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/custom/webkit-transform-crash.html

• svg/SVGStyledTransformableElement.cpp:

(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
Add a null-renderer check.

LayoutTests:

• svg/custom/webkit-transform-crash-expected.txt: Added.
• svg/custom/webkit-transform-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/webkit-transform-crash-expected.txt (added)
• LayoutTests/svg/custom/webkit-transform-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGStyledTransformableElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-03  Florin Malita  <fmalita@google.com>
+
+        NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform
+        https://bugs.webkit.org/show_bug.cgi?id=75227
+
+        Reviewed by Dirk Schulze.
+
+        * svg/custom/webkit-transform-crash-expected.txt: Added.
+        * svg/custom/webkit-transform-crash.html: Added.
+
 2012-01-03  Alexis Menard  <alexis.menard@openbossa.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-03  Florin Malita  <fmalita@google.com>
+
+        NULL ptr in WebCore::SVGStyledTransformableElement::animatedLocalTransform
+        https://bugs.webkit.org/show_bug.cgi?id=75227
+
+        Reviewed by Dirk Schulze.
+
+        Test: svg/custom/webkit-transform-crash.html
+
+        * svg/SVGStyledTransformableElement.cpp:
+        (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
+        Add a null-renderer check.
+
 2012-01-03  Alexis Menard  <alexis.menard@openbossa.org>
 

trunk/Source/WebCore/svg/SVGStyledTransformableElement.cpp

@@ -65 +65 @@
 {
     AffineTransform matrix;
-    RenderStyle* style = renderer()->style();
+    RenderStyle* style = renderer() ? renderer()->style() : 0;
 
     // if CSS property was set, use that, otherwise fallback to attribute (if set)
-    if (style->hasTransform()) {
+    if (style && style->hasTransform()) {
         TransformationMatrix t;
         // For now, the transform-origin is not taken into account