Changeset 103974 in webkit


Ignore:
Timestamp:
Jan 3, 2012 3:20:43 PM (12 years ago)
Author:
alexis.menard@openbossa.org
Message:

getComputedStyle for list-style is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=75443

Reviewed by Tony Chang.

Source/WebCore:

Implement getComputedStyle for list-style.

Test: fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add new tests to make sure we return the correct values.

  • fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r103973 r103974  
     12012-01-03  Alexis Menard  <alexis.menard@openbossa.org>
     2
     3        getComputedStyle for list-style is not implemented.
     4        https://bugs.webkit.org/show_bug.cgi?id=75443
     5
     6        Reviewed by Tony Chang.
     7
     8        Add new tests to make sure we return the correct values.
     9
     10        * fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt: Added.
     11        * fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html: Added.
     12
    1132012-01-03  Tony Chang  <tony@chromium.org>
    214
  • trunk/Source/WebCore/ChangeLog

    r103972 r103974  
     12012-01-03  Alexis Menard  <alexis.menard@openbossa.org>
     2
     3        getComputedStyle for list-style is not implemented.
     4        https://bugs.webkit.org/show_bug.cgi?id=75443
     5
     6        Reviewed by Tony Chang.
     7
     8        Implement getComputedStyle for list-style.
     9
     10        Test: fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html
     11
     12        * css/CSSComputedStyleDeclaration.cpp:
     13        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
     14
    1152012-01-03  Adrienne Walker  <enne@google.com>
    216
  • trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r103953 r103974  
    21872187            return getCSSPropertyValuesForSidesShorthand(properties);
    21882188        }
    2189         case CSSPropertyListStyle:
    2190             break;
     2189        case CSSPropertyListStyle: {
     2190            const int properties[3] = { CSSPropertyListStyleType, CSSPropertyListStylePosition,
     2191                                        CSSPropertyListStyleImage };
     2192            return getCSSPropertyValuesForShorthandProperties(properties, WTF_ARRAY_LENGTH(properties));
     2193        }
    21912194        case CSSPropertyMargin: {
    21922195            const int properties[4] = { CSSPropertyMarginTop, CSSPropertyMarginRight,
Note: See TracChangeset for help on using the changeset viewer.