Changeset 104308 in webkit

Timestamp:

Jan 6, 2012 11:51:19 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Use VectorMath lib when possible to optimize the processing in WebAudio AudioBus
​https://bugs.webkit.org/show_bug.cgi?id=75334

Patch by Wei James <​james.wei@intel.com> on 2012-01-06
Reviewed by Kenneth Russell.

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/AudioBus.cpp (modified) (9 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-06  Wei James  <james.wei@intel.com>
+
+        Use VectorMath lib when possible to optimize the processing in WebAudio AudioBus
+        https://bugs.webkit.org/show_bug.cgi?id=75334
+
+        Reviewed by Kenneth Russell.
+
+        * platform/audio/AudioBus.cpp:
+        (WebCore::AudioBus::processWithGainFromMonoStereo):
+
 2012-01-06  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/audio/AudioBus.cpp

@@ -245 +245 @@
     } \
     gain = totalDesiredGain; \
-    for (; k < framesToProcess; ++k)  \
-        OP
+    OP##_V 
 
 #define STEREO_SUM \
@@ -255 +254 @@
         *destinationR++ = sumR; \
     }
+
+// FIXME: this can be optimized with additional VectorMath functions. 
+#define STEREO_SUM_V \
+    for (; k < framesToProcess; ++k) \
+        STEREO_SUM
 
 // Mono -> stereo (mix equally into L and R)
@@ -267 +271 @@
     }
 
+#define MONO2STEREO_SUM_V \
+    for (; k < framesToProcess; ++k) \
+        MONO2STEREO_SUM 
+    
 #define MONO_SUM \
     { \
@@ -272 +280 @@
         *destinationL++ = sum; \
     }
+
+#define MONO_SUM_V \
+    for (; k < framesToProcess; ++k) \
+        MONO_SUM
 
 #define STEREO_NO_SUM \
@@ -281 +293 @@
     }
 
+#define STEREO_NO_SUM_V \
+    { \
+        vsmul(sourceL, 1, &gain, destinationL, 1, framesToProcess - k); \
+        vsmul(sourceR, 1, &gain, destinationR, 1, framesToProcess - k); \
+    }
+
 // Mono -> stereo (mix equally into L and R)
 // FIXME: Really we should apply an equal-power scaling factor here, since we're effectively panning center...
@@ -290 +308 @@
     }
 
+#define MONO2STEREO_NO_SUM_V \
+    { \
+        vsmul(sourceL, 1, &gain, destinationL, 1, framesToProcess - k); \
+        vsmul(sourceL, 1, &gain, destinationR, 1, framesToProcess - k); \
+    }
+
 #define MONO_NO_SUM \
     { \
@@ -296 +320 @@
     }
 
+#define MONO_NO_SUM_V \
+    { \
+        vsmul(sourceL, 1, &gain, destinationL, 1, framesToProcess - k); \
+    } 
+
 void AudioBus::processWithGainFromMonoStereo(const AudioBus &sourceBus, double* lastMixGain, double targetGain, bool sumToBus)
 {
@@ -301 +330 @@
     // so we "de-zipper" by slowly changing the gain each sample-frame until we've achieved the target gain.
 
-    // FIXME: optimize this method (SSE, etc.)
     // FIXME: targetGain and lastMixGain should be changed to floats instead of doubles.
     
@@ -352 +380 @@
             return;
 
-        // FIXME: if (framesToDezipper == 0) and DenormalDisabler::flushDenormalFloatToZero() is a NOP (gcc vs. Visual Studio) 
-        // then we can further optimize the PROCESS_WITH_GAIN codepaths below using vsmul().
         if (sourceR && destinationR) {
             // Stereo