Changeset 104403 in webkit


Ignore:
Timestamp:
Jan 8, 2012 10:05:51 AM (12 years ago)
Author:
noam.rosenthal@nokia.com
Message:

[Qt] Enable CSS_FILTERS in Qt build
​https://bugs.webkit.org/show_bug.cgi?id=75777

Source/WebCore:

Enable CSS_FILTERS and unskip the tests.

Reviewed by Kenneth Rohde Christiansen.

Filter tests are now unskipped for Qt.

  • Target.pri: add missing files to build.

Source/WebKit/qt:

For now, disallow compositing for filters. We will change that trigger when
​https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.

Reviewed by Kenneth Rohde Christiansen.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::allowedCompositingTriggers):

Tools:

Add the CSS_FILTERS feature flag to Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:

LayoutTests:

Reviewed by Kenneth Rohde Christiansen.

  • platform/qt/Skipped: Unskip filter tests that work.
  • platform/qt/css3/filters/*: Added Qt specific results.
Location:
trunk
Files:
55 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r104399 r104403  
     12012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
     2
     3        [Qt] Enable CSS_FILTERS in Qt build
     4        https://bugs.webkit.org/show_bug.cgi?id=75777
     5
     6        Reviewed by Kenneth Rohde Christiansen.
     7
     8        * platform/qt/Skipped: Unskip filter tests that work.
     9        * platform/qt/css3/filters/*: Added Qt specific results.
     10
    1112012-01-07  Antti Koivisto  <antti@apple.com>
    212

  • trunk/LayoutTests/platform/qt/Skipped

    r104398 r104403  
    238238css3/font-feature-settings-rendering.html
    239239
    240 # CSS Filters is disabled
    241 css3/filters
     240# CSS Filters - some tests don't work yet.
     241css3/filters/custom-filter-property-computed-style.html
     242css3/filters/custom-filter-property-parsing-invalid.html
     243css3/filters/custom-filter-property-parsing.html
     244css3/filters/filter-animation-from-none.html
     245css3/filters/filter-animation.html
     246css3/filters/filter-property-computed-style.html
     247css3/filters/filter-property-parsing-invalid.html
     248css3/filters/filter-property-parsing.html
     249css3/filters/filter-property.html
     250css3/filters/filter-repaint.html
     251css3/filters/crash-hw-sw-switch.html
     252css3/filters/effect-blur-hw.html
     253css3/filters/effect-combined.html
     254css3/filters/effect-combined-hw.html
     255css3/filters/effect-custom.html
     256css3/filters/effect-drop-shadow-hw.html
     257css3/filters/effect-grayscale-hw.html
     258css3/filters/effect-hue-rotate-hw.html
     259css3/filters/effect-invert-hw.html
     260css3/filters/effect-opacity-hw.html
     261css3/filters/effect-saturate-hw.html
     262css3/filters/effect-sepia-hw.html
    242263
    243264# Support multipart responses is not implemented.

  • trunk/Source/WebCore/ChangeLog

    r104399 r104403  
     12012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
     2
     3        [Qt] Enable CSS_FILTERS in Qt build
     4        https://bugs.webkit.org/show_bug.cgi?id=75777
     5
     6        Enable CSS_FILTERS and unskip the tests.
     7
     8        Reviewed by Kenneth Rohde Christiansen.
     9
     10        Filter tests are now unskipped for Qt.
     11
     12        * Target.pri: add missing files to build.
     13
    1142012-01-07  Antti Koivisto  <antti@apple.com>
    215

  • trunk/Source/WebCore/Target.pri

    r104385 r104403  
    11711171    rendering/CounterNode.cpp \
    11721172    rendering/EllipsisBox.cpp \
     1173    rendering/FilterEffectRenderer.cpp \
    11731174    rendering/FixedTableLayout.cpp \
    11741175    rendering/HitTestingTransformState.cpp \
    … …  
    22852286    rendering/CounterNode.h \
    22862287    rendering/EllipsisBox.h \
     2288    rendering/FilterEffectRenderer.h \
    22872289    rendering/FixedTableLayout.h \
    22882290    rendering/HitTestingTransformState.h \

  • trunk/Source/WebKit/qt/ChangeLog

    r104244 r104403  
     12012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
     2
     3        [Qt] Enable CSS_FILTERS in Qt build
     4        https://bugs.webkit.org/show_bug.cgi?id=75777
     5
     6        For now, disallow compositing for filters. We will change that trigger when
     7        https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.
     8
     9        Reviewed by Kenneth Rohde Christiansen.
     10
     11        * WebCoreSupport/ChromeClientQt.cpp:
     12        (WebCore::ChromeClientQt::allowedCompositingTriggers):
     13
    1142012-01-05  Sheriff Bot  <webkit.review.bot@gmail.com>
    215

  • trunk/Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

    r102874 r104403  
    631631{
    632632    if (platformPageClient() && platformPageClient()->allowsAcceleratedCompositing())
    633         return AllTriggers;
     633        return ThreeDTransformTrigger | VideoTrigger | CanvasTrigger | AnimationTrigger;
    634634
    635635    return 0;

  • trunk/Tools/ChangeLog

    r104402 r104403  
     12012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
     2
     3        [Qt] Enable CSS_FILTERS in Qt build
     4        https://bugs.webkit.org/show_bug.cgi?id=75777
     5
     6        Add the CSS_FILTERS feature flag to Qt.
     7
     8        Reviewed by Kenneth Rohde Christiansen.
     9
     10        * qmake/mkspecs/features/features.prf:
     11
    1122012-01-04  Kentaro Hara  <haraken@chromium.org>
    213

  • trunk/Tools/qmake/mkspecs/features/features.prf

    r104167 r104403  
    6565!contains(DEFINES, ENABLE_DASHBOARD_SUPPORT=.): DEFINES += ENABLE_DASHBOARD_SUPPORT=0
    6666!contains(DEFINES, ENABLE_FILTERS=.): DEFINES += ENABLE_FILTERS=1
     67!contains(DEFINES, ENABLE_CSS_FILTERS=.): DEFINES += ENABLE_CSS_FILTERS=1
    6768!contains(DEFINES, ENABLE_SHARED_WORKERS=.): DEFINES += ENABLE_SHARED_WORKERS=1
    6869!contains(DEFINES, ENABLE_WORKERS=.): DEFINES += ENABLE_WORKERS=1
    … …  
    215216contains(DEFINES, ENABLE_XSLT=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_XSLT=1
    216217contains(DEFINES, ENABLE_FILTERS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_FILTERS=1
     218contains(DEFINES, ENABLE_CSS_FILTERS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_CSS_FILTERS=1
    217219contains(DEFINES, ENABLE_SVG=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG=1
    218220contains(DEFINES, ENABLE_SVG_FONTS=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_SVG_FONTS=1
Note: See TracChangeset for help on using the changeset viewer.