Changeset 104475 in webkit


Ignore:
Timestamp:
Jan 9, 2012 12:17:09 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

[GStreamer] webkitwebsrc: pad template is leaked
https://bugs.webkit.org/show_bug.cgi?id=74224

Patch by Judy Hao <judy.liqiong-hao@nokia.com> on 2012-01-09
Reviewed by Philippe Normand.

Use a GstPadTemplate smart pointer in webkit_web_src_init to
avoid a memory leak.

Fixing memory leaks. So, no new test case is introduced.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r104474 r104475  
     12012-01-09  Judy Hao  <judy.liqiong-hao@nokia.com>
     2
     3        [GStreamer] webkitwebsrc: pad template is leaked
     4        https://bugs.webkit.org/show_bug.cgi?id=74224
     5
     6        Reviewed by Philippe Normand.
     7
     8        Use a GstPadTemplate smart pointer in webkit_web_src_init to
     9        avoid a memory leak.
     10
     11        Fixing memory leaks. So, no new test case is introduced.
     12
     13        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
     14        (webkit_web_src_init):
     15
    1162012-01-09  Xianzhu Wang  <wangxianzhu@chromium.org>
    217
  • trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

    r99977 r104475  
    213213static void webkit_web_src_init(WebKitWebSrc* src)
    214214{
    215     GstPadTemplate* padTemplate = gst_static_pad_template_get(&srcTemplate);
     215    GRefPtr<GstPadTemplate> padTemplate = adoptGRef(gst_static_pad_template_get(&srcTemplate));
    216216    WebKitWebSrcPrivate* priv = WEBKIT_WEB_SRC_GET_PRIVATE(src);
    217217
     
    233233
    234234    GRefPtr<GstPad> targetPad = adoptGRef(gst_element_get_static_pad(GST_ELEMENT(priv->appsrc), "src"));
    235     priv->srcpad = gst_ghost_pad_new_from_template("src", targetPad.get(), padTemplate);
     235    priv->srcpad = gst_ghost_pad_new_from_template("src", targetPad.get(), padTemplate.get());
    236236
    237237    gst_element_add_pad(GST_ELEMENT(src), priv->srcpad);
Note: See TracChangeset for help on using the changeset viewer.