Changeset 104483 in webkit


Ignore:
Timestamp:
Jan 9, 2012 1:16:17 PM (12 years ago)
Author:
Adam Roben
Message:

Convert Cygwin paths to Windows paths before passing them to DRT

Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
NRWT

I couldn't find a way to test this because I couldn't figure out how to override the
cygpath function as it is used by WebKitDriver.

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
Windows-style path before passing it to DRT.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r104482 r104483  
     12012-01-09  Adam Roben  <aroben@apple.com>
     2
     3        Convert Cygwin paths to Windows paths before passing them to DRT
     4
     5        Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
     6        NRWT
     7
     8        I couldn't find a way to test this because I couldn't figure out how to override the
     9        cygpath function as it is used by WebKitDriver.
     10
     11        Reviewed by Dirk Pranke.
     12
     13        * Scripts/webkitpy/layout_tests/port/webkit.py:
     14        (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
     15        Windows-style path before passing it to DRT.
     16
    1172012-01-06  Dirk Pranke  <dpranke@chromium.org>
    218
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py

    r104340 r104483  
    4444from webkitpy.common.system.environment import Environment
    4545from webkitpy.common.system.executive import Executive, ScriptError
     46from webkitpy.common.system.path import cygpath
    4647from webkitpy.layout_tests.port import builders, server_process, Port, Driver, DriverOutput
    4748
     
    526527        else:
    527528            command = self._port.abspath_for_test(driver_input.test_name)
     529            if sys.platform == 'cygwin':
     530                command = cygpath(command)
    528531
    529532        if driver_input.image_hash:
Note: See TracChangeset for help on using the changeset viewer.