Changeset 104775 in webkit

Timestamp:

Jan 11, 2012 5:24:23 PM (12 years ago)

Author:

abarth@webkit.org

Message:

iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control)
​https://bugs.webkit.org/show_bug.cgi?id=76120

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/forms/no-autofocus-in-sandbox.html

• html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

• The HTML5 spec says that we shouldn't autofocus elements when the automatic features are sandboxed.

LayoutTests:

• fast/forms/no-autofocus-in-sandbox-expected.txt: Added.
• fast/forms/no-autofocus-in-sandbox.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/no-autofocus-in-sandbox-expected.txt (added)
• LayoutTests/fast/forms/no-autofocus-in-sandbox.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLFormControlElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-11  Adam Barth  <abarth@webkit.org>
+
+        iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control)
+        https://bugs.webkit.org/show_bug.cgi?id=76120
+
+        Reviewed by Eric Seidel.
+
+        * fast/forms/no-autofocus-in-sandbox-expected.txt: Added.
+        * fast/forms/no-autofocus-in-sandbox.html: Added.
+
 2012-01-11  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-11  Adam Barth  <abarth@webkit.org>
+
+        iframe sandbox doesn't block autofocus (IETC automatic-feature-block-autofocus-form-control)
+        https://bugs.webkit.org/show_bug.cgi?id=76120
+
+        Reviewed by Eric Seidel.
+
+        Test: fast/forms/no-autofocus-in-sandbox.html
+
+        * html/HTMLFormControlElement.cpp:
+        (WebCore::shouldAutofocus):
+            - The HTML5 spec says that we shouldn't autofocus elements when the
+              automatic features are sandboxed.
+
 2012-01-11  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/html/HTMLFormControlElement.cpp

@@ -140 +140 @@
     if (element->document()->ignoreAutofocus())
         return false;
+    if (element->document()->isSandboxed(SandboxAutomaticFeatures))
+        return false;
     if (element->hasAutofocused())
         return false;