Changeset 104858 in webkit

Timestamp:

Jan 12, 2012 2:13:35 PM (12 years ago)

Author:

jer.noble@apple.com

Message:

WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.
​https://bugs.webkit.org/show_bug.cgi?id=74326

Reviewed by Darin Adler.

No new tests; no net change in functionality.

Use NSDataReadingMappedIfSafe when reading platform audio file data.

• platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/mac/AudioBusMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-12-12  Jer Noble  <jer.noble@apple.com>
+
+        WebAudio: AudioBus::loadPlatformResource should mmap file on Mac port.
+        https://bugs.webkit.org/show_bug.cgi?id=74326
+
+        Reviewed by Darin Adler.
+
+        No new tests; no net change in functionality.
+
+        Use NSDataReadingMappedIfSafe when reading platform audio file data.
+
+        * platform/audio/mac/AudioBusMac.mm:
+        (WebCore::AudioBus::loadPlatformResource):
+
 2011-12-12  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/audio/mac/AudioBusMac.mm

@@ -48 +48 @@
     
     NSBundle *bundle = [NSBundle bundleForClass:[WebCoreAudioBundleClass class]];
-    NSString *audioFilePath = [bundle pathForResource:[NSString stringWithUTF8String:name] ofType:@"wav" inDirectory:@"audio"];
-    NSData *audioData = [NSData dataWithContentsOfFile:audioFilePath];
+    NSURL *audioFileURL = [bundle URLForResource:[NSString stringWithUTF8String:name] withExtension:@"wav" subdirectory:@"audio"];
+    NSData *audioData = [NSData dataWithContentsOfURL:audioFileURL options:NSDataReadingMappedIfSafe error:nil];
 
     if (audioData) {