Changeset 104895 in webkit
- Timestamp:
- Jan 12, 2012 8:44:06 PM (12 years ago)
- Location:
- trunk/Source
- Files:
-
- 5 edited
- 1 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r104886 r104895 1 2012-01-12 David Levin <levin@chromium.org> 2 3 HwndDC is a better name than OwnGetDC. 4 https://bugs.webkit.org/show_bug.cgi?id=76235 5 6 Reviewed by Dmitry Titov. 7 8 This is a better name for two reasons: 9 1. "Own" implies "delete". In this case, the final call is a release (ReleaseDC). 10 2. "Ref" would be a better name due to the release but the RefPtr (and OwnPtr) 11 classes always take something to hold on to. In this case, the object (the DC) 12 is created by the class once it is given a Window to ensure that the HDC 13 was actually created using GetDC. 14 15 * JavaScriptCore.gyp/JavaScriptCore.gyp: 16 * JavaScriptCore.gypi: 17 * wtf/win/HwndDCWin.h: Renamed from Source/JavaScriptCore/wtf/win/OwnGetDCWin.h. 18 (WTF::HwndDC::HwndDC): 19 (WTF::HwndDC::~HwndDC): 20 (WTF::HwndDC::operator HDC): 21 1 22 2012-01-12 Gavin Barraclough <barraclough@apple.com> 2 23 -
trunk/Source/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp
r104867 r104895 174 174 ['exclude', 'OSAllocatorPosix\\.cpp$'], 175 175 ['include', 'OSAllocatorWin\\.cpp$'], 176 ['include', 'win/ OwnGetDCWin\\.h$'],176 ['include', 'win/HwndDCWin\\.h$'], 177 177 ], 178 178 'include_dirs!': [ -
trunk/Source/JavaScriptCore/JavaScriptCore.gypi
r104867 r104895 649 649 'wtf/unicode/wince/UnicodeWinCE.h', 650 650 'wtf/win/MainThreadWin.cpp', 651 'wtf/win/ OwnGetDCWin.h',651 'wtf/win/HwndDCWin.h', 652 652 'wtf/win/OwnPtrWin.cpp', 653 653 'wtf/wince/FastMallocWinCE.h', -
trunk/Source/JavaScriptCore/wtf/win/HwndDCWin.h
r104894 r104895 28 28 namespace WTF { 29 29 30 class OwnGetDC {30 class HwndDC { 31 31 public: 32 explicit OwnGetDC(HWND hwnd)32 explicit HwndDC(HWND hwnd) 33 33 : m_hwnd(hwnd) 34 34 , m_hdc(::GetDC(hwnd)) … … 36 36 } 37 37 38 ~ OwnGetDC()38 ~HwndDC() 39 39 { 40 40 if (m_hdc) … … 54 54 } 55 55 56 using WTF:: OwnGetDC;56 using WTF::HwndDC; -
trunk/Source/WebKit/chromium/ChangeLog
r104867 r104895 1 2012-01-12 David Levin <levin@chromium.org> 2 3 HwndDC is a better name than OwnGetDC. 4 https://bugs.webkit.org/show_bug.cgi?id=76235 5 6 Reviewed by Dmitry Titov. 7 8 * src/win/WebScreenInfoFactory.cpp: 9 (WebKit::WebScreenInfoFactory::screenInfo): 10 1 11 2012-01-12 David Levin <levin@chromium.org> 2 12 -
trunk/Source/WebKit/chromium/src/win/WebScreenInfoFactory.cpp
r104867 r104895 34 34 #include "WebScreenInfo.h" 35 35 36 #include <wtf/win/ OwnGetDCWin.h>36 #include <wtf/win/HwndDCWin.h> 37 37 38 38 #include <windows.h> … … 63 63 EnumDisplaySettings(monitorInfo.szDevice, ENUM_CURRENT_SETTINGS, &devMode); 64 64 65 OwnGetDC hdc(0);65 HwndDC hdc(0); 66 66 ASSERT(hdc); 67 67
Note: See TracChangeset
for help on using the changeset viewer.