Changeset 104907 in webkit


Ignore:
Timestamp:
Jan 13, 2012 1:17:42 AM (12 years ago)
Author:
haraken@chromium.org
Message:

text-decorations should not be propagated to floating, absolutely or fixed
positioned decendants
​https://bugs.webkit.org/show_bug.cgi?id=18611

Reviewed by Darin Adler.

Source/WebCore:

Previously text-decorations were propagated to all child elements,
but they should not be propagated to out-of-flow descendants,
i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
​http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

Test: fast/css/text-decoration-in-descendants.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

LayoutTests:

The added test checks that text-decorations are not propagated to out-of-flow
descendants, i.e. floating, absolutely or fixed positioned elements.

The spec says "text decorations are not propagated to any out-of-flow descendants":
​http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration

  • fast/css/text-decoration-in-descendants-expected.html: Added.
  • fast/css/text-decoration-in-descendants.html: Added.
  • platform/chromium-linux/fast/repaint/focus-layers-expected.png: Updated the test result.
  • platform/mac/fast/repaint/focus-layers-expected.png: Ditto.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r104906 r104907  
     12012-01-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        text-decorations should not be propagated to floating, absolutely or fixed
     4        positioned decendants
     5        https://bugs.webkit.org/show_bug.cgi?id=18611
     6
     7        Reviewed by Darin Adler.
     8
     9        The added test checks that text-decorations are not propagated to out-of-flow
     10        descendants, i.e. floating, absolutely or fixed positioned elements.
     11
     12        The spec says "text decorations are not propagated to any out-of-flow descendants":
     13        http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
     14
     15        * fast/css/text-decoration-in-descendants-expected.html: Added.
     16        * fast/css/text-decoration-in-descendants.html: Added.
     17        * platform/chromium-linux/fast/repaint/focus-layers-expected.png: Updated the test result.
     18        * platform/mac/fast/repaint/focus-layers-expected.png: Ditto.
     19
    1202012-01-13  Kent Tamura  <tkent@chromium.org>
    221

  • trunk/Source/WebCore/ChangeLog

    r104906 r104907  
     12012-01-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        text-decorations should not be propagated to floating, absolutely or fixed
     4        positioned decendants
     5        https://bugs.webkit.org/show_bug.cgi?id=18611
     6
     7        Reviewed by Darin Adler.
     8
     9        Previously text-decorations were propagated to all child elements,
     10        but they should not be propagated to out-of-flow descendants,
     11        i.e. floating, absolutely or fixed positioned elements.
     12
     13        The spec says "text decorations are not propagated to any out-of-flow descendants":
     14        http://www.w3.org/TR/2011/WD-css3-text-20110901/#decoration
     15
     16        Test: fast/css/text-decoration-in-descendants.html
     17
     18        * rendering/RenderObject.cpp:
     19        (WebCore::RenderObject::getTextDecorationColors):
     20
    1212012-01-13  Kent Tamura  <tkent@chromium.org>
    222

  • trunk/Source/WebCore/rendering/RenderObject.cpp

    r104802 r104907  
    24882488            }
    24892489        }
     2490        if (curr->isFloating() || curr->isPositioned())
     2491            return;
    24902492        curr = curr->parent();
    24912493        if (curr && curr->isAnonymousBlock() && toRenderBlock(curr)->continuation())
Note: See TracChangeset for help on using the changeset viewer.