Changeset 105286 in webkit


Ignore:
Timestamp:
Jan 18, 2012 9:40:46 AM (12 years ago)
Author:
sergio@webkit.org
Message:

[GTK] [regression] A couple of tests failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76549

Reviewed by Gustavo Noronha Silva.

Fixes a regression added by r105253. The method that
RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
instead of popsMenuByArrowKeys().

No new tests as it's already covered by
fast/forms/select-popup-pagekeys.html and
fast/forms/select/menulist-onchange-fired-with-key-up-down.html
that started to fail after the revision mentioned above.

  • platform/gtk/RenderThemeGtk.h:

(WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r105282 r105286  
     12012-01-18  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        [GTK] [regression] A couple of tests failing after r105253
     4        https://bugs.webkit.org/show_bug.cgi?id=76549
     5
     6        Reviewed by Gustavo Noronha Silva.
     7
     8        Fixes a regression added by r105253. The method that
     9        RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
     10        instead of popsMenuByArrowKeys().
     11
     12        No new tests as it's already covered by
     13        fast/forms/select-popup-pagekeys.html and
     14        fast/forms/select/menulist-onchange-fired-with-key-up-down.html
     15        that started to fail after the revision mentioned above.
     16
     17        * platform/gtk/RenderThemeGtk.h:
     18        (WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):
     19
    1202012-01-18  Andrey Kosyakov  <caseq@chromium.org>
    221
  • trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h

    r105253 r105286  
    8383    virtual Color systemColor(int cssValueId) const;
    8484
    85     virtual bool popsMenuByArrowKeys() const OVERRIDE { return true; }
     85    virtual bool popsMenuBySpaceOrReturn() const OVERRIDE { return true; }
    8686
    8787#if ENABLE(VIDEO)
Note: See TracChangeset for help on using the changeset viewer.