Changeset 105370 in webkit

Timestamp:

Jan 18, 2012 6:02:04 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Save two ID checks on CSS Min/Width property validation
​https://bugs.webkit.org/show_bug.cgi?id=76565

The same validation is done again in the next case statement. Check for
CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value
is a number.

Patch by Thiago Marcos P. Santos <​tmpsantos@gmail.com> on 2012-01-18
Reviewed by Andreas Kling.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-18  Thiago Marcos P. Santos  <tmpsantos@gmail.com>
+
+        Save two ID checks on CSS Min/Width property validation
+        https://bugs.webkit.org/show_bug.cgi?id=76565
+
+        The same validation is done again in the next case statement. Check for
+        CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value
+        is a number.
+
+        Reviewed by Andreas Kling.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseValue):
+
 2012-01-18  Dana Jansens  <danakj@chromium.org>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -1316 +1316 @@
     case CSSPropertyWebkitMaxLogicalWidth:
     case CSSPropertyWebkitMaxLogicalHeight:
-        if (id == CSSValueNone || id == CSSValueIntrinsic || id == CSSValueMinIntrinsic) {
+        if (id == CSSValueNone) {
             validPrimitive = true;
             break;