Changeset 105496 in webkit
- Timestamp:
- Jan 20, 2012 1:57:24 AM (12 years ago)
- Location:
- trunk/Tools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r105474 r105496 1 2012-01-20 Mario Sanchez Prada <msanchez@igalia.com> 2 3 [GTK] GTK's DRT not to log events for already defunct objects 4 https://bugs.webkit.org/show_bug.cgi?id=76620 5 6 Reviewed by Martin Robinson. 7 8 Do not log 'state-change:defunct' events. 9 10 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp: 11 (printAccessibilityEvent): Early return if a 12 'state-change:defunct' signal is passed. 13 (axObjectEventListener): Pass the signal name and value in 14 separate parameters to printAccessibilityEvent. 15 1 16 2012-01-19 Gustavo Noronha Silva <gns@gnome.org> 2 17 -
trunk/Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp
r101951 r105496 44 44 static guint visibleDataChangedListenerId = 0; 45 45 46 static void printAccessibilityEvent(AtkObject* accessible, const gchar* signalName )46 static void printAccessibilityEvent(AtkObject* accessible, const gchar* signalName, const gchar* signalValue) 47 47 { 48 // Sanity check. 49 if (!accessible || !ATK_IS_OBJECT(accessible) || !signalName) 48 // Do not handle state-change:defunct signals, as the AtkObject 49 // associated to them will not be valid at this point already. 50 if (!signalName || !g_strcmp0(signalName, "state-change:defunct")) 51 return; 52 53 if (!accessible || !ATK_IS_OBJECT(accessible)) 50 54 return; 51 55 52 56 const gchar* objectName = atk_object_get_name(accessible); 53 guintobjectRole = atk_object_get_role(accessible);57 AtkRole objectRole = atk_object_get_role(accessible); 54 58 55 59 // Try to always provide a name to be logged for the object. … … 57 61 objectName = "(No name)"; 58 62 63 GOwnPtr<gchar> signalNameAndValue(signalValue ? g_strdup_printf("%s = %s", signalName, signalValue) : g_strdup(signalName)); 59 64 printf("Accessibility object emitted \"%s\" / Name: \"%s\" / Role: %d\n", 60 signalName , objectName, objectRole);65 signalNameAndValue.get(), objectName, objectRole); 61 66 } 62 67 … … 76 81 GSignalQuery signal_query; 77 82 GOwnPtr<gchar> signalName; 83 GOwnPtr<gchar> signalValue; 78 84 79 85 g_signal_query(signalHint->signal_id, &signal_query); 80 86 81 87 if (!g_strcmp0(signal_query.signal_name, "state-change")) { 82 signalName.set(g_strdup_printf("state-change:%s = %d", 83 g_value_get_string(¶mValues[1]), 84 g_value_get_boolean(¶mValues[2]))); 88 signalName.set(g_strdup_printf("state-change:%s", g_value_get_string(¶mValues[1]))); 89 signalValue.set(g_strdup_printf("%d", g_value_get_boolean(¶mValues[2]))); 85 90 } else if (!g_strcmp0(signal_query.signal_name, "focus-event")) { 86 signalName.set(g_strdup _printf("focus-event = %d",87 91 signalName.set(g_strdup("focus-event")); 92 signalValue.set(g_strdup_printf("%d", g_value_get_boolean(¶mValues[1]))); 88 93 } else if (!g_strcmp0(signal_query.signal_name, "children-changed")) { 89 signalName.set(g_strdup _printf("children-changed = %d",90 94 signalName.set(g_strdup("children-changed")); 95 signalValue.set(g_strdup_printf("%d", g_value_get_uint(¶mValues[1]))); 91 96 } else if (!g_strcmp0(signal_query.signal_name, "property-change")) { 92 signalName.set(g_strdup_printf("property-change:%s", 93 g_quark_to_string(signalHint->detail))); 97 signalName.set(g_strdup_printf("property-change:%s", g_quark_to_string(signalHint->detail))); 94 98 } else 95 99 signalName.set(g_strdup(signal_query.signal_name)); 96 100 97 printAccessibilityEvent(accessible, signalName.get() );101 printAccessibilityEvent(accessible, signalName.get(), signalValue.get()); 98 102 99 103 return TRUE;
Note: See TracChangeset
for help on using the changeset viewer.