Changeset 105607 in webkit


Ignore:
Timestamp:
Jan 23, 2012 3:43:28 AM (12 years ago)
Author:
mario@webkit.org
Message:

[GTK] Refactor GTK's accessibilitity code to be more modular
​https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Source/WebCore:

Rename WebKitAccessible's public functions to follow WebKit's
coding style and update callers.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleNew): Renamed from webkit_accessible_new.
(webkitAccessibleGetAccessibilityObject): Likewise.
(webkitAccessibleDetach):Likewise.
(webkitAccessibleGetFocusedElement): Likewise.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.h:

Update calls to WebKitAccessible's public functions.

  • accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::detachWrapper): Update call.
(WebCore::AXObjectCache::attachWrapper): Ditto.

  • accessibility/gtk/WebKitAccessibleHyperlink.cpp:

(core): Update call.

Source/WebKit/gtk:

Update callers to WebKitAccessible's public functions.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
(modifyAccessibilityValue):
(DumpRenderTreeSupportGtk::accessibilityHelpText):

Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r105605 r105607  
     12012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        [GTK] Refactor GTK's accessibilitity code to be more modular
     4        https://bugs.webkit.org/show_bug.cgi?id=76783
     5
     6        Reviewed by Martin Robinson.
     7
     8        Rename WebKitAccessible's public functions to follow WebKit's
     9        coding style and update callers.
     10
     11        * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
     12        (webkitAccessibleNew): Renamed from webkit_accessible_new.
     13        (webkitAccessibleGetAccessibilityObject): Likewise.
     14        (webkitAccessibleDetach):Likewise.
     15        (webkitAccessibleGetFocusedElement): Likewise.
     16        * accessibility/gtk/WebKitAccessibleWrapperAtk.h:
     17
     18        Update calls to WebKitAccessible's public functions.
     19
     20        * accessibility/gtk/AXObjectCacheAtk.cpp:
     21        (WebCore::AXObjectCache::detachWrapper): Update call.
     22        (WebCore::AXObjectCache::attachWrapper): Ditto.
     23        * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
     24        (core): Update call.
     25
    1262012-01-19  Kenichi Ishibashi  <bashi@chromium.org>
    227

  • trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp

    r105604 r105607  
    3434void AXObjectCache::detachWrapper(AccessibilityObject* obj)
    3535{
    36     webkit_accessible_detach(WEBKIT_ACCESSIBLE(obj->wrapper()));
     36    webkitAccessibleDetach(WEBKIT_ACCESSIBLE(obj->wrapper()));
    3737}
    3838
    3939void AXObjectCache::attachWrapper(AccessibilityObject* obj)
    4040{
    41     AtkObject* atkObj = ATK_OBJECT(webkit_accessible_new(obj));
     41    AtkObject* atkObj = ATK_OBJECT(webkitAccessibleNew(obj));
    4242    obj->setWrapper(atkObj);
    4343    g_object_unref(atkObj);

  • trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp

    r105604 r105607  
    6666        return 0;
    6767
    68     return webkit_accessible_get_accessibility_object(accessible);
     68    return webkitAccessibleGetAccessibilityObject(accessible);
    6969}
    7070

  • trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp

    r105604 r105607  
    26812681}
    26822682
    2683 WebKitAccessible* webkit_accessible_new(AccessibilityObject* coreObject)
     2683WebKitAccessible* webkitAccessibleNew(AccessibilityObject* coreObject)
    26842684{
    26852685    GType type = getAccessibilityTypeFromObject(coreObject);
    … …  
    26912691}
    26922692
    2693 AccessibilityObject* webkit_accessible_get_accessibility_object(WebKitAccessible* accessible)
     2693AccessibilityObject* webkitAccessibleGetAccessibilityObject(WebKitAccessible* accessible)
    26942694{
    26952695    return accessible->m_object;
    26962696}
    26972697
    2698 void webkit_accessible_detach(WebKitAccessible* accessible)
     2698void webkitAccessibleDetach(WebKitAccessible* accessible)
    26992699{
    27002700    ASSERT(accessible->m_object);
    … …  
    27092709}
    27102710
    2711 AtkObject* webkit_accessible_get_focused_element(WebKitAccessible* accessible)
     2711AtkObject* webkitAccessibleGetFocusedElement(WebKitAccessible* accessible)
    27122712{
    27132713    if (!accessible->m_object)

  • trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.h

    r105604 r105607  
    5252GType webkit_accessible_get_type(void) G_GNUC_CONST;
    5353
    54 WebKitAccessible* webkit_accessible_new(WebCore::AccessibilityObject*);
     54WebKitAccessible* webkitAccessibleNew(WebCore::AccessibilityObject*);
    5555
    56 WebCore::AccessibilityObject* webkit_accessible_get_accessibility_object(WebKitAccessible*);
     56WebCore::AccessibilityObject* webkitAccessibleGetAccessibilityObject(WebKitAccessible*);
    5757
    58 void webkit_accessible_detach(WebKitAccessible*);
     58void webkitAccessibleDetach(WebKitAccessible*);
    5959
    60 AtkObject* webkit_accessible_get_focused_element(WebKitAccessible*);
     60AtkObject* webkitAccessibleGetFocusedElement(WebKitAccessible*);
    6161
    6262WebCore::AccessibilityObject* objectFocusedAndCaretOffsetUnignored(WebCore::AccessibilityObject*, int& offset);

  • trunk/Source/WebKit/gtk/ChangeLog

    r105604 r105607  
     12012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        [GTK] Refactor GTK's accessibilitity code to be more modular
     4        https://bugs.webkit.org/show_bug.cgi?id=76783
     5
     6        Reviewed by Martin Robinson.
     7
     8        Update callers to WebKitAccessible's public functions.
     9
     10        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
     11        (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
     12        (modifyAccessibilityValue):
     13        (DumpRenderTreeSupportGtk::accessibilityHelpText):
     14
    1152012-01-22  Mario Sanchez Prada  <msanchez@igalia.com>
    216

  • trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

    r105604 r105607  
    485485        return 0;
    486486
    487     return webkit_accessible_get_focused_element(WEBKIT_ACCESSIBLE(wrapper));
     487    return webkitAccessibleGetFocusedElement(WEBKIT_ACCESSIBLE(wrapper));
    488488#else
    489489    return 0;
    … …  
    762762        return;
    763763
    764     AccessibilityObject* coreObject = webkit_accessible_get_accessibility_object(WEBKIT_ACCESSIBLE(axObject));
     764    AccessibilityObject* coreObject = webkitAccessibleGetAccessibilityObject(WEBKIT_ACCESSIBLE(axObject));
    765765    if (!coreObject)
    766766        return;
    … …  
    787787        return CString();
    788788
    789     AccessibilityObject* coreObject = webkit_accessible_get_accessibility_object(WEBKIT_ACCESSIBLE(axObject));
     789    AccessibilityObject* coreObject = webkitAccessibleGetAccessibilityObject(WEBKIT_ACCESSIBLE(axObject));
    790790    if (!coreObject)
    791791        return CString();
Note: See TracChangeset for help on using the changeset viewer.