Changeset 105610 in webkit


Ignore:
Timestamp:
Jan 23, 2012 3:55:01 AM (12 years ago)
Author:
mario@webkit.org
Message:

[GTK] Refactor GTK's accessibilitity code to be more modular
​https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Move common function returnString() from the wrapper and
hyperlink implementations to a new utility file.

  • accessibility/gtk/WebKitAccessibleUtil.cpp: Added.

(returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
WebKitAccessibleHyperlink.cpp

  • accessibility/gtk/WebKitAccessibleUtil.h: Added.
  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local

implementation of returnString.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.

Add new files to build files.

  • GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
  • WebCore.gypi: Ditto.
Location:
trunk/Source/WebCore
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r105608 r105610  
     12012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
     2
     3        [GTK] Refactor GTK's accessibilitity code to be more modular
     4        https://bugs.webkit.org/show_bug.cgi?id=76783
     5
     6        Reviewed by Martin Robinson.
     7
     8        Move common function returnString() from the wrapper and
     9        hyperlink implementations to a new utility file.
     10
     11        * accessibility/gtk/WebKitAccessibleUtil.cpp: Added.
     12        (returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
     13        WebKitAccessibleHyperlink.cpp
     14        * accessibility/gtk/WebKitAccessibleUtil.h: Added.
     15
     16        * accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local
     17        implementation of returnString.
     18        * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.
     19
     20        Add new files to build files.
     21
     22        * GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
     23        * WebCore.gypi: Ditto.
     24
    1252012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
    226

  • trunk/Source/WebCore/GNUmakefile.list.am

    r105604 r105610  
    44254425        Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.h \
    44264426        Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp \
     4427        Source/WebCore/accessibility/gtk/WebKitAccessibleUtil.cpp \
     4428        Source/WebCore/accessibility/gtk/WebKitAccessibleUtil.h \
    44274429        Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp \
    44284430        Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.h \

  • trunk/Source/WebCore/WebCore.gypi

    r105604 r105610  
    17691769            'accessibility/gtk/WebKitAccessibleHyperlink.cpp',
    17701770            'accessibility/gtk/WebKitAccessibleHyperlink.h',
     1771            'accessibility/gtk/WebKitAccessibleUtil.cpp',
     1772            'accessibility/gtk/WebKitAccessibleUtil.h',
    17711773            'accessibility/gtk/WebKitAccessibleWrapperAtk.cpp',
    17721774            'accessibility/gtk/WebKitAccessibleWrapperAtk.h',

  • trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp

    r105608 r105610  
    3131#include "RenderObject.h"
    3232#include "TextIterator.h"
     33#include "WebKitAccessibleUtil.h"
    3334#include "WebKitAccessibleWrapperAtk.h"
    3435#include "htmlediting.h"
    … …  
    5253
    5354static gpointer webkitAccessibleHyperlinkParentClass = 0;
    54 
    55 // Used to provide const char* returns.
    56 static const char* returnString(const String& str)
    57 {
    58     static CString returnedString;
    59     returnedString = str.utf8();
    60     return returnedString.data();
    61 }
    6255
    6356static AccessibilityObject* core(WebKitAccessible* accessible)

  • trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp

    r105607 r105610  
    6464#include "TextIterator.h"
    6565#include "WebKitAccessibleHyperlink.h"
     66#include "WebKitAccessibleUtil.h"
    6667#include "htmlediting.h"
    6768#include "visible_units.h"
    … …  
    9192
    9293    return object;
    93 }
    94 
    95 // Used to provide const char* returns.
    96 static const char* returnString(const String& str)
    97 {
    98     static CString returnedString;
    99     returnedString = str.utf8();
    100     return returnedString.data();
    10194}
    10295
Note: See TracChangeset for help on using the changeset viewer.