Changeset 105643 in webkit


Ignore:
Timestamp:
Jan 23, 2012 2:37:54 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Update uniteIfNonZero to use isZero.
https://bugs.webkit.org/show_bug.cgi?id=76637

Patch by Philip Rogers <pdr@google.com> on 2012-01-23
Reviewed by Darin Adler.

No new tests. (I found no existing codepath that would be affected by
this change but I think this change is still valuable in preventing
future bugs.)

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::uniteIfNonZero):

The following change is a minor followup to
https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
related to the rest of this patch.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r105642 r105643  
     12012-01-23  Philip Rogers  <pdr@google.com>
     2
     3        Update uniteIfNonZero to use isZero.
     4        https://bugs.webkit.org/show_bug.cgi?id=76637
     5
     6        Reviewed by Darin Adler.
     7
     8        No new tests. (I found no existing codepath that would be affected by
     9        this change but I think this change is still valuable in preventing
     10        future bugs.)
     11
     12        * platform/graphics/FloatRect.cpp:
     13        (WebCore::FloatRect::uniteIfNonZero):
     14
     15        The following change is a minor followup to
     16        https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
     17        related to the rest of this patch.
     18        * rendering/svg/SVGRenderSupport.cpp:
     19        (WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
     20
    1212012-01-23  Antti Koivisto  <antti@apple.com>
    222
  • trunk/Source/WebCore/platform/graphics/FloatRect.cpp

    r105231 r105643  
    120120{
    121121    // Handle empty special cases first.
    122     if (!other.width() && !other.height())
    123         return;
    124     if (!width() && !height()) {
     122    if (other.isZero())
     123        return;
     124    if (isZero()) {
    125125        *this = other;
    126126        return;
  • trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp

    r105231 r105643  
    191191        }
    192192
    193         if (isFirstChild)
    194             isFirstChild = false;
     193        isFirstChild = false;
    195194    }
    196195}
Note: See TracChangeset for help on using the changeset viewer.