Changeset 105820 in webkit


Ignore:
Timestamp:
Jan 24, 2012 3:21:09 PM (12 years ago)
Author:
tony@chromium.org
Message:

REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
https://bugs.webkit.org/show_bug.cgi?id=76317

Reviewed by Darin Adler.

Source/WebCore:

Test: scrollbars/scroll-rtl-or-bt-layer.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Call scrollToOffsetWithoutAnimation since we're always
scrolling to the just computed offset.

LayoutTests:

  • platform/win/Skipped:
  • scrollbars/scroll-rtl-or-bt-layer-expected.txt: Added.
  • scrollbars/scroll-rtl-or-bt-layer.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r105814 r105820  
     12012-01-24  Tony Chang  <tony@chromium.org>
     2
     3        REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
     4        https://bugs.webkit.org/show_bug.cgi?id=76317
     5
     6        Reviewed by Darin Adler.
     7
     8        * platform/win/Skipped:
     9        * scrollbars/scroll-rtl-or-bt-layer-expected.txt: Added.
     10        * scrollbars/scroll-rtl-or-bt-layer.html: Added.
     11
    1122012-01-24  David Levin  <levin@chromium.org>
    213
  • trunk/LayoutTests/platform/win/Skipped

    r105506 r105820  
    971971fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html
    972972scrollbars/scrollevent-iframe-no-scrolling-wheel.html
     973scrollbars/scroll-rtl-or-bt-layer.html
    973974
    974975# Windows port doesn't yet support rendering of non-BMP characters even though there's a font available.
  • trunk/Source/WebCore/ChangeLog

    r105819 r105820  
     12012-01-24  Tony Chang  <tony@chromium.org>
     2
     3        REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
     4        https://bugs.webkit.org/show_bug.cgi?id=76317
     5
     6        Reviewed by Darin Adler.
     7
     8        Test: scrollbars/scroll-rtl-or-bt-layer.html
     9
     10        * rendering/RenderLayer.cpp:
     11        (WebCore::RenderLayer::updateScrollInfoAfterLayout): Call scrollToOffsetWithoutAnimation since we're always
     12        scrolling to the just computed offset.
     13
    1142012-01-24  Mark Rowe  <mrowe@apple.com>
    215
  • trunk/Source/WebCore/rendering/RenderLayer.cpp

    r105739 r105820  
    22932293
    22942294    m_scrollDimensionsDirty = true;
     2295    IntSize scrollOffsetOriginal(scrollXOffset(), scrollYOffset());
    22952296
    22962297    bool horizontalOverflow, verticalOverflow;
     
    23752376        m_vBar->setProportion(clientHeight, m_scrollSize.height());
    23762377    }
    2377  
    2378     scrollToOffset(scrollXOffset(), scrollYOffset());
     2378
     2379    if (scrollOffsetOriginal != scrollOffset())
     2380        scrollToOffsetWithoutAnimation(LayoutPoint(scrollXOffset(), scrollYOffset()));
    23792381
    23802382    if (renderer()->node() && renderer()->document()->hasListenerType(Document::OVERFLOWCHANGED_LISTENER))
Note: See TracChangeset for help on using the changeset viewer.