Changeset 105906 in webkit


Ignore:
Timestamp:
Jan 25, 2012 11:53:05 AM (12 years ago)
Author:
shawnsingh@chromium.org
Message:

Fix the semantics of passing contentsVisible flag to GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=76975

Reviewed by Simon Fraser.

Source/WebCore:

This patch is covered by existing tests, in particular
compositing/visibility/layer-visible-content.html; its
expectations are rebaselined.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • compositing/visibility/layer-visible-content-expected.txt: rebaselined expectations.
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt: rebaselined expectations.
  • platform/chromium/test_expectations.txt: removed the expectation that the test fails on chromium, it should pass now.
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r105904 r105906  
     12012-01-25  Shawn Singh  <shawnsingh@chromium.org>
     2
     3        Fix the semantics of passing contentsVisible flag to GraphicsLayers
     4        https://bugs.webkit.org/show_bug.cgi?id=76975
     5
     6        Reviewed by Simon Fraser.
     7
     8        * compositing/visibility/layer-visible-content-expected.txt: rebaselined expectations.
     9        * compositing/visibility/visibility-image-layers-dynamic-expected.txt: rebaselined expectations.
     10        * platform/chromium/test_expectations.txt: removed the expectation that the test fails on chromium, it should pass now.
     11
    1122012-01-25  MORITA Hajime  <morrita@google.com>
    213

  • trunk/LayoutTests/compositing/visibility/layer-visible-content-expected.txt

    r105471 r105906  
    44    (GraphicsLayer
    55      (bounds 800.00 600.00)
    6       (children 1
     6      (children 2
    77        (GraphicsLayer
    88          (bounds 200.00 200.00)
    99          (drawsContent 1)
    10           (contentsVisible 0)
    1110          (children 1
    1211            (GraphicsLayer
    … …  
    2019          )
    2120        )
     21        (GraphicsLayer
     22          (bounds 800.00 15.00)
     23          (opacity 0.00)
     24          (drawsContent 1)
     25        )
    2226      )
    2327    )

  • trunk/LayoutTests/compositing/visibility/visibility-image-layers-dynamic-expected.txt

    r98735 r105906  
    3636          (position 14.00 314.00)
    3737          (bounds 757.00 152.00)
    38           (contentsVisible 0)
    3938          (children 1
    4039            (GraphicsLayer
    … …  
    5150
    5251(GraphicsLayer
    53   (bounds 785.00 1301.00)
     52  (bounds 785.00 1286.00)
    5453  (children 1
    5554    (GraphicsLayer
    56       (bounds 785.00 1301.00)
     55      (bounds 785.00 1286.00)
    5756      (children 3
    5857        (GraphicsLayer
    … …  
    8180          (position 14.00 314.00)
    8281          (bounds 757.00 152.00)
    83           (contentsVisible 0)
    8482          (children 1
    8583            (GraphicsLayer
    … …  
    9694
    9795(GraphicsLayer
    98   (bounds 785.00 1965.00)
     96  (bounds 785.00 1935.00)
    9997  (children 1
    10098    (GraphicsLayer
    101       (bounds 785.00 1965.00)
     99      (bounds 785.00 1935.00)
    102100      (children 3
    103101        (GraphicsLayer
    … …  
    125123          (position 14.00 314.00)
    126124          (bounds 757.00 152.00)
    127           (contentsVisible 0)
    128125          (children 1
    129126            (GraphicsLayer

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r105895 r105906  
    40054005BUGWK76572 : http/tests/download = FAIL
    40064006
    4007 BUGWK76716 : compositing/visibility/layer-visible-content.html = IMAGE+TEXT
    4008 
    40094007BUGWK76967 : media/media-fragments/TC0030-TC0039.html = PASS TIMEOUT
    40104008

  • trunk/Source/WebCore/ChangeLog

    r105903 r105906  
     12012-01-25  Shawn Singh  <shawnsingh@chromium.org>
     2
     3        Fix the semantics of passing contentsVisible flag to GraphicsLayers
     4        https://bugs.webkit.org/show_bug.cgi?id=76975
     5
     6        Reviewed by Simon Fraser.
     7
     8        This patch is covered by existing tests, in particular
     9        compositing/visibility/layer-visible-content.html; its
     10        expectations are rebaselined.
     11
     12        * rendering/RenderLayerBacking.cpp:
     13        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
     14
    1152012-01-25  Tony Chang  <tony@chromium.org>
    216

  • trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

    r105757 r105906  
    404404   
    405405    m_owningLayer->updateVisibilityStatus();
    406     m_graphicsLayer->setContentsVisible(m_owningLayer->hasVisibleContent());
     406
     407    // m_graphicsLayer is the corresponding GraphicsLayer for this RenderLayer and its non-compositing
     408    // descendants. So, the visibility flag for m_graphicsLayer should be true if there are any
     409    // non-compositing visible layers.
     410    m_graphicsLayer->setContentsVisible(m_owningLayer->hasVisibleContent() || m_owningLayer->hasVisibleDescendant());
    407411   
    408412    RenderStyle* style = renderer()->style();
Note: See TracChangeset for help on using the changeset viewer.