Changeset 105908 in webkit


Ignore:
Timestamp:
Jan 25, 2012 12:07:55 PM (12 years ago)
Author:
enrica@apple.com
Message:

WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm: Removed typingAttributes implementation.
  • WebView/WebView.mm:

(-[WebView typingAttributes]): Added.

Tools:

  • TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView

and WebHTMLView.
(TestWebKitAPI::TEST):

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/mac/ChangeLog

    r105829 r105908  
     12012-01-25  Enrica Casucci  <enrica@apple.com>
     2
     3        WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
     4        https://bugs.webkit.org/show_bug.cgi?id=76951
     5        <rdar://problem/9325158>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * WebView/WebHTMLView.mm: Removed typingAttributes implementation.
     10        * WebView/WebView.mm:
     11        (-[WebView typingAttributes]): Added.
     12
    1132012-01-24  Enrica Casucci  <enrica@apple.com>
    214
  • trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

    r105829 r105908  
    56875687}
    56885688
    5689 - (NSDictionary *)typingAttributes
    5690 {
    5691     Frame* coreFrame = core([self _frame]);
    5692     if (coreFrame)
    5693         return coreFrame->editor()->fontAttributesForSelectionStart();
    5694 
    5695     return nil;
    5696 }
    5697 
    56985689- (NSAttributedString *)attributedSubstringFromRange:(NSRange)nsRange
    56995690{
  • trunk/Source/WebKit/mac/WebView/WebView.mm

    r105552 r105908  
    55385538}
    55395539
     5540- (NSDictionary *)typingAttributes
     5541{
     5542    Frame* coreFrame = core([self _selectedOrMainFrame]);
     5543    if (coreFrame)
     5544        return coreFrame->editor()->fontAttributesForSelectionStart();
     5545   
     5546    return nil;
     5547}
     5548
     5549
    55405550@end
    55415551
  • trunk/Tools/ChangeLog

    r105900 r105908  
     12012-01-25  Enrica Casucci  <enrica@apple.com>
     2
     3        WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
     4        https://bugs.webkit.org/show_bug.cgi?id=76951
     5        <rdar://problem/9325158>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
     10        and WebHTMLView.
     11        (TestWebKitAPI::TEST):
     12
    1132012-01-23  MORITA Hajime  <morrita@google.com>
    214
  • trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm

    r105829 r105908  
    6464    [[document body] focus];
    6565   
    66     EXPECT_TRUE([[[[webView.get() mainFrame] frameView] documentView] respondsToSelector:@selector(typingAttributes)]);
    67     NSDictionary *attributes = [(id)[[[webView.get() mainFrame] frameView] documentView] typingAttributes];
     66    EXPECT_TRUE([webView.get() respondsToSelector:@selector(typingAttributes)]);
     67    NSDictionary *attributes = [(id)webView.get() typingAttributes];
    6868    [(id)[[[webView.get() mainFrame] frameView] documentView] doCommandBySelector:@selector(bold:)];
    6969    EXPECT_FALSE([attributes isEqual:[(id)[[[webView.get() mainFrame] frameView] documentView] typingAttributes]]);
Note: See TracChangeset for help on using the changeset viewer.