Changeset 105908 in webkit
- Timestamp:
- Jan 25, 2012 12:07:55 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/mac/ChangeLog
r105829 r105908 1 2012-01-25 Enrica Casucci <enrica@apple.com> 2 3 WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. 4 https://bugs.webkit.org/show_bug.cgi?id=76951 5 <rdar://problem/9325158> 6 7 Reviewed by Alexey Proskuryakov. 8 9 * WebView/WebHTMLView.mm: Removed typingAttributes implementation. 10 * WebView/WebView.mm: 11 (-[WebView typingAttributes]): Added. 12 1 13 2012-01-24 Enrica Casucci <enrica@apple.com> 2 14 -
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm
r105829 r105908 5687 5687 } 5688 5688 5689 - (NSDictionary *)typingAttributes5690 {5691 Frame* coreFrame = core([self _frame]);5692 if (coreFrame)5693 return coreFrame->editor()->fontAttributesForSelectionStart();5694 5695 return nil;5696 }5697 5698 5689 - (NSAttributedString *)attributedSubstringFromRange:(NSRange)nsRange 5699 5690 { -
trunk/Source/WebKit/mac/WebView/WebView.mm
r105552 r105908 5538 5538 } 5539 5539 5540 - (NSDictionary *)typingAttributes 5541 { 5542 Frame* coreFrame = core([self _selectedOrMainFrame]); 5543 if (coreFrame) 5544 return coreFrame->editor()->fontAttributesForSelectionStart(); 5545 5546 return nil; 5547 } 5548 5549 5540 5550 @end 5541 5551 -
trunk/Tools/ChangeLog
r105900 r105908 1 2012-01-25 Enrica Casucci <enrica@apple.com> 2 3 WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail. 4 https://bugs.webkit.org/show_bug.cgi?id=76951 5 <rdar://problem/9325158> 6 7 Reviewed by Alexey Proskuryakov. 8 9 * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView 10 and WebHTMLView. 11 (TestWebKitAPI::TEST): 12 1 13 2012-01-23 MORITA Hajime <morrita@google.com> 2 14 -
trunk/Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm
r105829 r105908 64 64 [[document body] focus]; 65 65 66 EXPECT_TRUE([ [[[webView.get() mainFrame] frameView] documentView]respondsToSelector:@selector(typingAttributes)]);67 NSDictionary *attributes = [(id) [[[webView.get() mainFrame] frameView] documentView]typingAttributes];66 EXPECT_TRUE([webView.get() respondsToSelector:@selector(typingAttributes)]); 67 NSDictionary *attributes = [(id)webView.get() typingAttributes]; 68 68 [(id)[[[webView.get() mainFrame] frameView] documentView] doCommandBySelector:@selector(bold:)]; 69 69 EXPECT_FALSE([attributes isEqual:[(id)[[[webView.get() mainFrame] frameView] documentView] typingAttributes]]);
Note: See TracChangeset
for help on using the changeset viewer.