Changeset 105916 in webkit
- Timestamp:
- Jan 25, 2012 12:37:13 PM (12 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit2/ChangeLog
r105893 r105916 1 2012-01-25 Martin Robinson <mrobinson@igalia.com> 2 3 [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions 4 https://bugs.webkit.org/show_bug.cgi?id=76344 5 6 Reviewed by Sam Weinig. 7 8 When creating InjectedBundleNavigationActions, initialize the mouse button to NoButton. 9 This ensures that when there is no mouse event associated with the action, when the event 10 hits the client-API layer, the button is still NoButton. 11 12 * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: 13 (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction): Initialize m_mouseButton 14 to WebMouseEvent::NoButton. 15 1 16 2012-01-25 Kenneth Rohde Christiansen <kenneth@webkit.org> 2 17 -
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp
r95901 r105916 87 87 88 88 InjectedBundleNavigationAction::InjectedBundleNavigationAction(WebFrame* frame, const NavigationAction& navigationAction, PassRefPtr<FormState> prpFormState) 89 : m_navigationType(navigationAction.type()) 90 , m_modifiers(modifiersForNavigationAction(navigationAction)) 91 , m_mouseButton(WebMouseEvent::NoButton) 89 92 { 90 m_navigationType = navigationAction.type();91 m_modifiers = modifiersForNavigationAction(navigationAction);92 93 93 if (const MouseEvent* mouseEvent = mouseEventForNavigationAction(navigationAction)) { 94 94 m_hitTestResult = InjectedBundleHitTestResult::create(frame->coreFrame()->eventHandler()->hitTestResultAtPoint(mouseEvent->absoluteLocation(), false)); -
trunk/Tools/ChangeLog
r105915 r105916 1 2012-01-25 Martin Robinson <mrobinson@igalia.com> 2 3 [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions 4 https://bugs.webkit.org/show_bug.cgi?id=76344 5 6 Reviewed by Sam Weinig. 7 8 Add a test verifying that the mouse button during policy decisions for 9 events not triggered by mouse events is NoButton. 10 11 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp: 12 (TestWebKitAPI::decidePolicyForNavigationAction): Added test. 13 (TestWebKitAPI::decidePolicyForNewWindowAction): Added test. 14 1 15 2012-01-25 Ryosuke Niwa <rniwa@webkit.org> 2 16 -
trunk/Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp
r95188 r105916 91 91 EXPECT_FALSE(state->didStartProvisionalLoadForFrame); 92 92 EXPECT_FALSE(state->didCommitLoadForFrame); 93 EXPECT_TRUE(mouseButton = kWKEventMouseButtonNoButton); 93 94 94 95 state->didDecidePolicyForNavigationAction = true; … … 99 100 static void decidePolicyForNewWindowAction(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, WKURLRequestRef request, WKStringRef frameName, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo) 100 101 { 102 EXPECT_TRUE(mouseButton = kWKEventMouseButtonNoButton); 101 103 WKFramePolicyListenerUse(listener); 102 104 }
Note: See TracChangeset
for help on using the changeset viewer.