Changeset 105940 in webkit


Ignore:
Timestamp:
Jan 25, 2012 4:17:59 PM (12 years ago)
Author:
eric@webkit.org
Message:

HTMLIsIndexElement should not expose HTMLInputElement properties
​https://bugs.webkit.org/show_bug.cgi?id=76095

Reviewed by Adam Barth.

Source/WebCore:

document.createElement("isindex") should produce an HTMLUnknownElement
per the HTML5 spec. The parser automagically translates <isindex> into
a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)

This patch just removes our support for HTMLIsIndexElement. The parser
support was already in. Having support for HTMLIsIndexElement was causing
one of the IE TestCenter tests to fail.

Test: fast/dom/HTMLIsIndexElement/prototype-chain.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:

(WebKit::createHTMLElementWrapper):

  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):

  • bindings/objc/DOMHTML.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLIsIndexElement.cpp: Removed.
  • html/HTMLIsIndexElement.h: Removed.
  • html/HTMLIsIndexElement.idl: Removed.
  • html/HTMLTagNames.in:
  • page/DOMWindow.idl:

Source/WebKit/mac:

  • MigrateHeaders.make:
Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r105938 r105940  
     12012-01-25  Eric Seidel  <eric@webkit.org>
     2
     3        HTMLIsIndexElement should not expose HTMLInputElement properties
     4        https://bugs.webkit.org/show_bug.cgi?id=76095
     5
     6        Reviewed by Adam Barth.
     7
     8        document.createElement("isindex") should produce an HTMLUnknownElement
     9        per the HTML5 spec.  The parser automagically translates <isindex> into
     10        a whole dom tree roughly representing what <isindex> used to do 15 years ago. :)
     11
     12        This patch just removes our support for HTMLIsIndexElement.  The parser
     13        support was already in.  Having support for HTMLIsIndexElement was causing
     14        one of the IE TestCenter tests to fail.
     15
     16        Test: fast/dom/HTMLIsIndexElement/prototype-chain.html
     17
     18        * DerivedSources.cpp:
     19        * DerivedSources.make:
     20        * DerivedSources.pri:
     21        * GNUmakefile.list.am:
     22        * Target.pri:
     23        * WebCore.exp.in:
     24        * WebCore.gypi:
     25        * WebCore.order:
     26        * WebCore.vcproj/WebCore.vcproj:
     27        * WebCore.xcodeproj/project.pbxproj:
     28        * bindings/gobject/GNUmakefile.am:
     29        * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
     30        (WebKit::createHTMLElementWrapper):
     31        * bindings/objc/DOM.mm:
     32        (WebCore::createElementClassMap):
     33        * bindings/objc/DOMHTML.h:
     34        * bindings/objc/PublicDOMInterfaces.h:
     35        * html/HTMLElementsAllInOne.cpp:
     36        * html/HTMLIsIndexElement.cpp: Removed.
     37        * html/HTMLIsIndexElement.h: Removed.
     38        * html/HTMLIsIndexElement.idl: Removed.
     39        * html/HTMLTagNames.in:
     40        * page/DOMWindow.idl:
     41
    1422012-01-25  Eric Seidel  <eric@webkit.org>
    243

  • trunk/Source/WebCore/DerivedSources.cpp

    r105922 r105940  
    169169#include "JSHTMLImageElement.cpp"
    170170#include "JSHTMLInputElement.cpp"
    171 #include "JSHTMLIsIndexElement.cpp"
    172171#include "JSHTMLKeygenElement.cpp"
    173172#include "JSHTMLLabelElement.cpp"

  • trunk/Source/WebCore/DerivedSources.make

    r105922 r105940  
    216216    $(WebCore)/html/HTMLImageElement.idl \
    217217    $(WebCore)/html/HTMLInputElement.idl \
    218     $(WebCore)/html/HTMLIsIndexElement.idl \
    219218    $(WebCore)/html/HTMLKeygenElement.idl \
    220219    $(WebCore)/html/HTMLLIElement.idl \

  • trunk/Source/WebCore/DerivedSources.pri

    r105922 r105940  
    281281    $$PWD/html/HTMLImageElement.idl \
    282282    $$PWD/html/HTMLInputElement.idl \
    283     $$PWD/html/HTMLIsIndexElement.idl \
    284283    $$PWD/html/HTMLKeygenElement.idl \
    285284    $$PWD/html/HTMLLabelElement.idl \

  • trunk/Source/WebKit/mac/ChangeLog

    r105922 r105940  
     12012-01-25  Eric Seidel  <eric@webkit.org>
     2
     3        HTMLIsIndexElement should not expose HTMLInputElement properties
     4        https://bugs.webkit.org/show_bug.cgi?id=76095
     5
     6        Reviewed by Adam Barth.
     7
     8        * MigrateHeaders.make:
     9
    1102012-01-25  Hajime Morita  <morrita@google.com>
    211
Note: See TracChangeset for help on using the changeset viewer.