Changeset 105980 in webkit

Timestamp:

Jan 26, 2012 2:07:12 AM (12 years ago)

Author:

tkent@chromium.org

Message:

Unreviewed, rolling out r105968.
​http://trac.webkit.org/changeset/105968
​https://bugs.webkit.org/show_bug.cgi?id=76995

Incorrect behavior change

Source/WebCore:

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setIndeterminate):

LayoutTests:

• fast/forms/indeterminate-radio.html:
• fast/forms/radio-checkbox-restore-indeterminate.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/indeterminate-radio.html (modified) (1 diff)
• LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-26  Kent Tamura  <tkent@chromium.org>
+
+        Unreviewed, rolling out r105968.
+        http://trac.webkit.org/changeset/105968
+        https://bugs.webkit.org/show_bug.cgi?id=76995
+
+        Incorrect behavior change
+
+        * fast/forms/indeterminate-radio.html:
+        * fast/forms/radio-checkbox-restore-indeterminate.html:
+
 2012-01-26  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/LayoutTests/fast/forms/indeterminate-radio.html

@@ -6 +6 @@
     div
     {
-        color: green;
+        color: red;
     }
     input:indeterminate + #test
     {
-        color: red;
+        color: green;
     }
 </style>

trunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.html

@@ -68 +68 @@
 
         log('<br>Checking whether default-prevented click clobbered indeterminate state:')
-        log('On checked radio button: ' + (!radio3.indeterminate ? 'PASS' : 'FAIL'));
-        log('On unchecked radio button: ' + (!radio4.indeterminate ? 'PASS' : 'FAIL'));
+        log('On checked radio button: ' + (radio3.indeterminate ? 'PASS' : 'FAIL'));
+        log('On unchecked radio button: ' + (radio4.indeterminate ? 'PASS' : 'FAIL'));
         log('On checked checkbox: ' + (check1.indeterminate ? 'PASS' : 'FAIL'));
         log('On unchecked checkbox: ' + (check2.indeterminate ? 'PASS' : 'FAIL'));

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-26  Kent Tamura  <tkent@chromium.org>
+
+        Unreviewed, rolling out r105968.
+        http://trac.webkit.org/changeset/105968
+        https://bugs.webkit.org/show_bug.cgi?id=76995
+
+        Incorrect behavior change
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setIndeterminate):
+
 2012-01-26  Nikolas Zimmermann  <nzimmermann@rim.com>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -947 +947 @@
 void HTMLInputElement::setIndeterminate(bool newValue)
 {
-    if (!isCheckbox() || indeterminate() == newValue)
+    if (!m_inputType->isCheckable() || indeterminate() == newValue)
         return;