Changeset 106153 in webkit

Timestamp:

Jan 27, 2012 2:43:34 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Asm-originated symbols should be marked as hidden
​https://bugs.webkit.org/show_bug.cgi?id=77150

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2012-01-27
Reviewed by Filip Pizlo.

• dfg/DFGOperations.cpp: The HIDE_SYMBOLS macros were present in the CPU(ARM) preprocessor branches,

but they were missing in the CPU(X86) and the CPU(X86_64) cases.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGOperations.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-01-27  Simon Hausmann  <simon.hausmann@nokia.com>
+
+        [JSC] Asm-originated symbols should be marked as hidden
+        https://bugs.webkit.org/show_bug.cgi?id=77150
+
+        Reviewed by Filip Pizlo.
+
+        * dfg/DFGOperations.cpp: The HIDE_SYMBOLS macros were present in the CPU(ARM) preprocessor branches,
+        but they were missing in the CPU(X86) and the CPU(X86_64) cases.
+
 2012-01-27  MORITA Hajime  <morrita@google.com>
 

trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

@@ -44 +44 @@
     asm( \
     ".globl " SYMBOL_STRING(function) "\n" \
+    HIDE_SYMBOL(function) "\n" \
     SYMBOL_STRING(function) ":" "\n" \
         "mov (%rsp), %" STRINGIZE(register) "\n" \
@@ -58 +59 @@
     asm( \
     ".globl " SYMBOL_STRING(function) "\n" \
+    HIDE_SYMBOL(function) "\n" \
     SYMBOL_STRING(function) ":" "\n" \
         "mov (%esp), %eax\n" \
@@ -678 +680 @@
 asm (
 ".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
+HIDE_SYMBOL(getHostCallReturnValue) "\n"
 SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
     "mov -40(%r13), %r13\n"
@@ -686 +689 @@
 asm (
 ".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"
+HIDE_SYMBOL(getHostCallReturnValue) "\n"
 SYMBOL_STRING(getHostCallReturnValue) ":" "\n"
     "mov -40(%edi), %edi\n"