Changeset 106231 in webkit

Timestamp:

Jan 30, 2012 4:10:14 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt] Add "New Window" button to the Qt MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=77281

Patch by Alexander Færøy <​ahf@0x90.dk> on 2012-01-30
Reviewed by Tor Arne Vestbø.

• MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):

• MiniBrowser/qt/MiniBrowser.qrc:
• MiniBrowser/qt/icons/plus.png: Added.
• MiniBrowser/qt/qml/BrowserWindow.qml:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/qt/BrowserWindow.cpp (modified) (1 diff)
• MiniBrowser/qt/MiniBrowser.qrc (modified) (1 diff)
• MiniBrowser/qt/icons/plus.png (added)
• MiniBrowser/qt/qml/BrowserWindow.qml (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2012-01-30  Alexander Færøy  <ahf@0x90.dk>
+
+        [Qt] Add "New Window" button to the Qt MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=77281
+
+        Reviewed by Tor Arne Vestbø.
+
+        * MiniBrowser/qt/BrowserWindow.cpp:
+        (BrowserWindow::BrowserWindow):
+        * MiniBrowser/qt/MiniBrowser.qrc:
+        * MiniBrowser/qt/icons/plus.png: Added.
+        * MiniBrowser/qt/qml/BrowserWindow.qml:
+
 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp

@@ -54 +54 @@
     setSource(QUrl("qrc:/qml/BrowserWindow.qml"));
     connect(rootObject(), SIGNAL(pageTitleChanged(QString)), this, SLOT(setWindowTitle(QString)));
+    connect(rootObject(), SIGNAL(newWindow(QString)), this, SLOT(newWindow(QString)));
     if (options->useTraditionalDesktopBehavior())
         webView()->experimental()->setUseTraditionalDesktopBehaviour(true);

trunk/Tools/MiniBrowser/qt/MiniBrowser.qrc

@@ -3 +3 @@
         <file>icons/info.png</file>
         <file>icons/next.png</file>
+        <file>icons/plus.png</file>
         <file>icons/previous.png</file>
         <file>icons/refresh.png</file>

trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml

@@ -37 +37 @@
 
     signal pageTitleChanged(string title)
+    signal newWindow(string url)
 
     function load(address) {
@@ -207 +208 @@
 
                         options.touchMockingEnabled = !options.touchMockingEnabled
+                    }
+                }
+            }
+
+            Rectangle {
+                id: newBrowserWindowButton
+                height: parent.height
+                width: height
+                color: "#efefef"
+                radius: 6
+
+                Image {
+                    anchors.centerIn: parent
+                    source: "../icons/plus.png"
+                }
+
+                MouseArea {
+                    anchors.fill: parent
+                    onClicked: {
+                        newWindow("about:blank")
                     }
                 }