Changeset 106246 in webkit


Ignore:
Timestamp:
Jan 30, 2012 8:40:55 AM (12 years ago)
Author:
pfeldman@chromium.org
Message:

Web Inspector: protocol validator should fail if one of response fields turns optional
https://bugs.webkit.org/show_bug.cgi?id=76452

Reviewed by Yury Semikhatsky.

  • inspector/Inspector-0.1.json:
  • inspector/Inspector.json:
  • inspector/generate-inspector-protocol-version:

(compare_commands):
(compare_events):
(compare_params_list):
(compare_types):
(self_test):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r106245 r106246  
     12012-01-30  Pavel Feldman  <pfeldman@google.com>
     2
     3        Web Inspector: protocol validator should fail if one of response fields turns optional
     4        https://bugs.webkit.org/show_bug.cgi?id=76452
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * inspector/Inspector-0.1.json:
     9        * inspector/Inspector.json:
     10        * inspector/generate-inspector-protocol-version:
     11        (compare_commands):
     12        (compare_events):
     13        (compare_params_list):
     14        (compare_types):
     15        (self_test):
     16
    1172012-01-30  Yury Semikhatsky  <yurys@chromium.org>
    218
  • trunk/Source/WebCore/inspector/Inspector.json

    r106101 r106246  
    368368                    { "name": "value", "type": "any", "optional": true, "description": "Remote object value (in case of primitive values or JSON values if it was requested)." },
    369369                    { "name": "description", "type": "string", "optional": true, "description": "String representation of the object." },
    370                     { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Unique object identifier (for non-primitive values)." },
    371                     { "name": "functionName", "type": "string", "optional": true, "description": "User-friendly name of the function represented by this object." }
     370                    { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Unique object identifier (for non-primitive values)." }
    372371                ]
    373372            },
  • trunk/Source/WebCore/inspector/generate-inspector-protocol-version

    r96398 r106246  
    124124
    125125        param_2 = params_2[name]
     126        if param_2 and "optional" in param_2 and not "optional" in param_1:
     127            errors.append("required parameter is now optional: %s" % name)
     128            continue;
    126129        type_1 = extract_type(param_1, types_map_1, errors)
    127130        type_2 = extract_type(param_2, types_map_2, errors)
     
    227230                    "returns": [
    228231                        { "name": "mimeType", "type": "string" },
     232                        { "name": "nonOptionalMimeType", "type": "string" },
    229233                        { "name": "optionalMimeType", "type": "string", "optional": True }
    230234                    ]
     
    274278                    "parameters": [
    275279                        { "name": "headers", "type": "object" },
     280                    ],
     281                    "returns": [
     282                        { "name": "nonOptionalMimeType", "type": "string", "optional": True }
    276283                    ]
    277284                }
     
    292299        "Network.setUserAgentOverride: command is missing",
    293300        "Network.setExtraHTTPHeaders: required parameter is missing: mimeType",
     301        "Network.setExtraHTTPHeaders: required parameter is now optional: nonOptionalMimeType",
    294302        "Network.loadingFailed: event is missing",
    295303        "Network.requestWillBeSent: required parameter is missing: postData",
Note: See TracChangeset for help on using the changeset viewer.