Changeset 106246 in webkit
- Timestamp:
- Jan 30, 2012 8:40:55 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r106245 r106246 1 2012-01-30 Pavel Feldman <pfeldman@google.com> 2 3 Web Inspector: protocol validator should fail if one of response fields turns optional 4 https://bugs.webkit.org/show_bug.cgi?id=76452 5 6 Reviewed by Yury Semikhatsky. 7 8 * inspector/Inspector-0.1.json: 9 * inspector/Inspector.json: 10 * inspector/generate-inspector-protocol-version: 11 (compare_commands): 12 (compare_events): 13 (compare_params_list): 14 (compare_types): 15 (self_test): 16 1 17 2012-01-30 Yury Semikhatsky <yurys@chromium.org> 2 18 -
trunk/Source/WebCore/inspector/Inspector.json
r106101 r106246 368 368 { "name": "value", "type": "any", "optional": true, "description": "Remote object value (in case of primitive values or JSON values if it was requested)." }, 369 369 { "name": "description", "type": "string", "optional": true, "description": "String representation of the object." }, 370 { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Unique object identifier (for non-primitive values)." }, 371 { "name": "functionName", "type": "string", "optional": true, "description": "User-friendly name of the function represented by this object." } 370 { "name": "objectId", "$ref": "RemoteObjectId", "optional": true, "description": "Unique object identifier (for non-primitive values)." } 372 371 ] 373 372 }, -
trunk/Source/WebCore/inspector/generate-inspector-protocol-version
r96398 r106246 124 124 125 125 param_2 = params_2[name] 126 if param_2 and "optional" in param_2 and not "optional" in param_1: 127 errors.append("required parameter is now optional: %s" % name) 128 continue; 126 129 type_1 = extract_type(param_1, types_map_1, errors) 127 130 type_2 = extract_type(param_2, types_map_2, errors) … … 227 230 "returns": [ 228 231 { "name": "mimeType", "type": "string" }, 232 { "name": "nonOptionalMimeType", "type": "string" }, 229 233 { "name": "optionalMimeType", "type": "string", "optional": True } 230 234 ] … … 274 278 "parameters": [ 275 279 { "name": "headers", "type": "object" }, 280 ], 281 "returns": [ 282 { "name": "nonOptionalMimeType", "type": "string", "optional": True } 276 283 ] 277 284 } … … 292 299 "Network.setUserAgentOverride: command is missing", 293 300 "Network.setExtraHTTPHeaders: required parameter is missing: mimeType", 301 "Network.setExtraHTTPHeaders: required parameter is now optional: nonOptionalMimeType", 294 302 "Network.loadingFailed: event is missing", 295 303 "Network.requestWillBeSent: required parameter is missing: postData",
Note: See TracChangeset
for help on using the changeset viewer.