Changeset 106287 in webkit

Timestamp:

Jan 30, 2012 2:01:42 PM (12 years ago)

Author:

jocelyn.turcotte@nokia.com

Message:

[Qt] Disconnect the LayerTreeHost from layers when they get removed from their parent.
​https://bugs.webkit.org/show_bug.cgi?id=77362

Reviewed by Noam Rosenthal.

This fixes crashes seen in layout tests under certain timing circumstances
that appeared after r106109 was landed.

• WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebCoreSupport/WebGraphicsLayer.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2012-01-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
+
+        [Qt] Disconnect the LayerTreeHost from layers when they get removed from their parent.
+        https://bugs.webkit.org/show_bug.cgi?id=77362
+
+        Reviewed by Noam Rosenthal.
+
+        This fixes crashes seen in layout tests under certain timing circumstances
+        that appeared after r106109 was landed.
+
+        * WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
+        (WebCore::WebGraphicsLayer::replaceChild):
+        (WebCore::WebGraphicsLayer::removeFromParent):
+
 2012-01-30  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp

@@ -163 +163 @@
     notifyChange();
     toWebGraphicsLayer(oldChild)->notifyChange();
+    toWebGraphicsLayer(oldChild)->setLayerTreeTileClient(0);
     toWebGraphicsLayer(newChild)->setVisibleContentRectAndScale(m_pageVisibleRect, m_contentsScale);
     toWebGraphicsLayer(newChild)->notifyChange();
@@ -175 +176 @@
 
     notifyChange();
+    setLayerTreeTileClient(0);
 }