Changeset 106294 in webkit


Ignore:
Timestamp:
Jan 30, 2012 3:16:11 PM (12 years ago)
Author:
tony@chromium.org
Message:

css3/flexbox/cross-axis-scrollbar.html ref test fails on Windows Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=77309

Reviewed by Dirk Pranke.

It looks like the scrollbars on windows overflow by a pixel, so the
edge of the scrollbar is being covered up by the trailing green box.
Use z-order to force the scrollbar on top.

This is kind of speculative. I want to see if the test passes on the
bots before removing the line in test_expectations.txt.

  • css3/flexbox/cross-axis-scrollbar-expected.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r106285 r106294  
     12012-01-30  Tony Chang  <tony@chromium.org>
     2
     3        css3/flexbox/cross-axis-scrollbar.html ref test fails on Windows Chromium bots
     4        https://bugs.webkit.org/show_bug.cgi?id=77309
     5
     6        Reviewed by Dirk Pranke.
     7
     8        It looks like the scrollbars on windows overflow by a pixel, so the
     9        edge of the scrollbar is being covered up by the trailing green box.
     10        Use z-order to force the scrollbar on top.
     11
     12        This is kind of speculative. I want to see if the test passes on the
     13        bots before removing the line in test_expectations.txt.
     14
     15        * css3/flexbox/cross-axis-scrollbar-expected.html:
     16
    1172012-01-30  Levi Weintraub  <leviw@chromium.org>
    218
  • trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html

    r106129 r106294  
    2323<div class="testcase" style="top:0; left: 0">
    2424    <div style="width: 100px; height: 50px"></div>
    25     <div style="width: 100px; overflow-x: scroll"></div>
    26     <div style="width: 100px; height: 10px"></div>
     25    <div style="width: 100px; overflow-x: scroll; position: relative; z-index: 1"></div>
     26    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    2727</div>
    2828
    2929<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 150px">
    3030    <div style="width: 100px"></div>
    31     <div style="overflow-y: scroll"></div>
    32     <div style="width: 10px"></div>
     31    <div style="overflow-y: scroll; position: relative; z-index: 1"></div>
     32    <div style="width: 10px; position: relative; z-index: -1"></div>
    3333</div>
    3434
    3535<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 300px">
    3636    <div style="width: 100px"></div>
    37     <div style="overflow-y: scroll"></div>
    38     <div style="width: 10px"></div>
     37    <div style="overflow-y: scroll; position: relative; z-index: 1"></div>
     38    <div style="width: 10px; position: relative; z-index: -1"></div>
    3939</div>
    4040
    4141<div class="testcase" style="top: 0; left: 450px">
    4242    <div style="width: 100px; height: 50px"></div>
    43     <div style="width: 100px; overflow-x: scroll"></div>
    44     <div style="width: 100px; height: 10px"></div>
     43    <div style="width: 100px; overflow-x: scroll; position: relative; z-index: 1"></div>
     44    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    4545</div>
    4646
    4747<div class="testcase" style="top: 100px; left: 0">
    4848    <div style="width: 100px; height: 50px; "></div>
    49     <div style="width: 100px; overflow-x: scroll"></div>
    50     <div style="width: 100px; height: 10px"></div>
     49    <div style="width: 100px; overflow-x: scroll; position: relative; z-index: 1"></div>
     50    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    5151</div>
    5252
    5353<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 150px">
    54     <div style="width: 90px; overflow-y: scroll"></div>
    55     <div style="width: 10px"></div>
     54    <div style="width: 90px; overflow-y: scroll; position: relative; z-index: 1"></div>
     55    <div style="width: 10px; position: relative; z-index: -1"></div>
    5656</div>
    5757
    5858<div class="testcase" style="top: 100px; left: 300px">
    59     <div style="width: 100px; height: 40px; overflow-x: scroll"></div>
    60     <div style="width: 100px; height: 10px"></div>
     59    <div style="width: 100px; height: 40px; overflow-x: scroll; position: relative; z-index: 1"></div>
     60    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    6161</div>
    6262
    6363<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 450px">
    6464    <div style="width: 100px"></div>
    65     <div style="overflow-y: scroll"></div>
    66     <div style="width: 10px"></div>
     65    <div style="overflow-y: scroll; position: relative; z-index: 1"></div>
     66    <div style="width: 10px; position: relative; z-index: -1"></div>
    6767</div>
    6868
Note: See TracChangeset for help on using the changeset viewer.