Changeset 106318 in webkit

Timestamp:

Jan 30, 2012 6:55:08 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Don't select the next selectable index when deselecting an option in select elements with size set to a value greater than one.
​https://bugs.webkit.org/show_bug.cgi?id=76389

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-01-30
Reviewed by Kent Tamura.

This behavior matches the rest of the browsers.

Source/WebCore:

Test: fast/forms/select/option-selecting.html

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionSelectionStateChanged):

LayoutTests:

• fast/forms/select/option-selecting-expected.txt: Added.
• fast/forms/select/option-selecting.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/select/option-selecting-expected.txt (added)
• LayoutTests/fast/forms/select/option-selecting.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLSelectElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-30  Pablo Flouret  <pablof@motorola.com>
+
+        Don't select the next selectable index when deselecting an option in select elements with size set to a value greater than one.
+        https://bugs.webkit.org/show_bug.cgi?id=76389
+
+        Reviewed by Kent Tamura.
+
+        This behavior matches the rest of the browsers.
+
+        * fast/forms/select/option-selecting-expected.txt: Added.
+        * fast/forms/select/option-selecting.html: Added.
+
 2012-01-30  Levi Weintraub  <leviw@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-30  Pablo Flouret  <pablof@motorola.com>
+
+        Don't select the next selectable index when deselecting an option in select elements with size set to a value greater than one.
+        https://bugs.webkit.org/show_bug.cgi?id=76389
+
+        Reviewed by Kent Tamura.
+
+        This behavior matches the rest of the browsers.
+
+        Test: fast/forms/select/option-selecting.html
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::optionSelectionStateChanged):
+
 2012-01-30  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/html/HTMLSelectElement.cpp

@@ -768 +768 @@
     if (optionIsSelected)
         selectOption(option->index());
+    else if (!usesMenuList())
+        selectOption(-1);
     else
-        selectOption(m_multiple ? -1 : nextSelectableListIndex(-1));
+        selectOption(nextSelectableListIndex(-1));
 }