Changeset 106354 in webkit

Timestamp:

Jan 31, 2012 4:11:35 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: show sizes in bytes instead of KB, MB in heap profiler.
​https://bugs.webkit.org/show_bug.cgi?id=77199

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-01-31
Reviewed by Pavel Feldman.

• inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):

• inspector/front-end/UIUtils.js:

(Number.withThousandsSeparator):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DetailedHeapshotGridNodes.js (modified) (4 diffs)
• inspector/front-end/UIUtils.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-31  Alexei Filippov  <alexeif@chromium.org>
+
+        Web Inspector: show sizes in bytes instead of KB, MB in heap profiler.
+        https://bugs.webkit.org/show_bug.cgi?id=77199
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/DetailedHeapshotGridNodes.js:
+        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
+        (WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
+        (WebInspector.HeapSnapshotConstructorNode.prototype.get data):
+        (WebInspector.HeapSnapshotDiffNode.prototype.get data):
+        * inspector/front-end/UIUtils.js:
+        (Number.withThousandsSeparator):
+
 2012-01-26  Hans Wennborg  <hans@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js

@@ -269 +269 @@
 
         var view = this.dataGrid.snapshotView;
-        data["shallowSize"] = view.showShallowSizeAsPercent ? WebInspector.UIString("%.2f%%", this._shallowSizePercent) : Number.bytesToString(this._shallowSize);
-        data["retainedSize"] = view.showRetainedSizeAsPercent ? WebInspector.UIString("%.2f%%", this._retainedSizePercent) : Number.bytesToString(this._retainedSize);
+        data["shallowSize"] = view.showShallowSizeAsPercent ? WebInspector.UIString("%.2f%%", this._shallowSizePercent) : Number.withThousandsSeparator(this._shallowSize);
+        data["retainedSize"] = view.showRetainedSizeAsPercent ? WebInspector.UIString("%.2f%%", this._retainedSizePercent) : Number.withThousandsSeparator(this._retainedSize);
 
         return this._enhanceData ? this._enhanceData(data) : data;
@@ -504 +504 @@
             data["addedSize"] = "";
             data["removedCount"] = "\u2022";
-            data["removedSize"] = Number.bytesToString(this._shallowSize);
+            data["removedSize"] = Number.withThousandsSeparator(this._shallowSize);
         } else {
             data["addedCount"] = "\u2022";
-            data["addedSize"] = Number.bytesToString(this._shallowSize);
+            data["addedSize"] = Number.withThousandsSeparator(this._shallowSize);
             data["removedCount"] = "";
             data["removedSize"] = "";
@@ -571 +571 @@
         var view = this.dataGrid.snapshotView;
         data["count"] = view.showCountAsPercent ? WebInspector.UIString("%.2f%%", this._countPercent) : this._count;
-        data["shallowSize"] = view.showShallowSizeAsPercent ? WebInspector.UIString("%.2f%%", this._shallowSizePercent) : Number.bytesToString(this._shallowSize);
-        data["retainedSize"] = "> " + (view.showRetainedSizeAsPercent ? WebInspector.UIString("%.2f%%", this._retainedSizePercent) : Number.bytesToString(this._retainedSize));
+        data["shallowSize"] = view.showShallowSizeAsPercent ? WebInspector.UIString("%.2f%%", this._shallowSizePercent) : Number.withThousandsSeparator(this._shallowSize);
+        data["retainedSize"] = view.showRetainedSizeAsPercent ? "~" + WebInspector.UIString("%.2f%%", this._retainedSizePercent) : Number.withThousandsSeparator(this._retainedSize) + "+";
         return data;
     },
@@ -752 +752 @@
         data["removedCount"] = this._removedCount;
         data["countDelta"] = WebInspector.UIString("%s%d", this._signForDelta(this._countDelta), Math.abs(this._countDelta));
-        data["addedSize"] = Number.bytesToString(this._addedSize);
-        data["removedSize"] = Number.bytesToString(this._removedSize);
-        data["sizeDelta"] = WebInspector.UIString("%s%s", this._signForDelta(this._sizeDelta), Number.bytesToString(Math.abs(this._sizeDelta)));
+        data["addedSize"] = Number.withThousandsSeparator(this._addedSize);
+        data["removedSize"] = Number.withThousandsSeparator(this._removedSize);
+        data["sizeDelta"] = WebInspector.UIString("%s%s", this._signForDelta(this._sizeDelta), Number.withThousandsSeparator(Math.abs(this._sizeDelta)));
 
         return data;

trunk/Source/WebCore/inspector/front-end/UIUtils.js

@@ -443 +443 @@
 }
 
+Number.withThousandsSeparator = function(num)
+{
+    var str = num + "";
+    var re = /(\d+)(\d{3})/;
+    while (str.match(re))
+        str = str.replace(re, "$1,$2");
+    return str;
+}
+
 WebInspector._missingLocalizedStrings = {};