Changeset 106368 in webkit

Timestamp:

Jan 31, 2012 10:06:23 AM (12 years ago)

Author:

andersca@apple.com

Message:

Vector<T>::operator== shouldn't require T to have operator!=
​https://bugs.webkit.org/show_bug.cgi?id=77448

Reviewed by Andreas Kling.

Change VectorComparer::compare to use !(a == b) instead of a != b since
it makes more sense for Vector::operator== to use the element's operator==.

• wtf/Vector.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/Vector.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-01-31  Anders Carlsson  <andersca@apple.com>
+
+        Vector<T>::operator== shouldn't require T to have operator!=
+        https://bugs.webkit.org/show_bug.cgi?id=77448
+
+        Reviewed by Andreas Kling.
+
+        Change VectorComparer::compare to use !(a == b) instead of a != b since
+        it makes more sense for Vector::operator== to use the element's operator==.
+
+        * wtf/Vector.h:
+
 2012-01-30  Oliver Hunt  <oliver@apple.com>
 

trunk/Source/JavaScriptCore/wtf/Vector.h

@@ -195 +195 @@
         {
             for (size_t i = 0; i < size; ++i)
-                if (a[i] != b[i])
+                if (!(a[i] == b[i]))
                     return false;
             return true;