Changeset 106378 in webkit


Ignore:
Timestamp:
Jan 31, 2012 12:05:29 PM (12 years ago)
Author:
tony@chromium.org
Message:

[chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on
chromium win.

The scrollbars overflow the bounds of the scrollbar rect (see bug 77368).
Work around this by using positioned elements and setting the z-index as
negative. It didn't work previously because when the scrollbar was
positioned, it clipped the extra pixels. Tested to verify that this works
on Chromium Win and Chromium Linux.

Unreviewed, test fix.

  • css3/flexbox/cross-axis-scrollbar-expected.html:
  • platform/chromium/test_expectations.txt:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r106373 r106378  
     12012-01-31  Tony Chang  <tony@chromium.org>
     2
     3        [chromium] Fix css3/flexbox/cross-axis-scrollbar-expected to work on
     4        chromium win.
     5
     6        The scrollbars overflow the bounds of the scrollbar rect (see bug 77368).
     7        Work around this by using positioned elements and setting the z-index as
     8        negative.  It didn't work previously because when the scrollbar was
     9        positioned, it clipped the extra pixels.  Tested to verify that this works
     10        on Chromium Win and Chromium Linux.
     11
     12        Unreviewed, test fix.
     13
     14        * css3/flexbox/cross-axis-scrollbar-expected.html:
     15        * platform/chromium/test_expectations.txt:
     16
    1172012-01-25  Eric Seidel  <eric@webkit.org>
    218

  • trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar-expected.html

    r106294 r106378  
    2323<div class="testcase" style="top:0; left: 0">
    2424    <div style="width: 100px; height: 50px"></div>
    25     <div style="width: 100px; overflow-x: scroll; position: relative; z-index: 1"></div>
     25    <div style="width: 100px; overflow-x: scroll"></div>
    2626    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    2727</div>
    … …  
    2929<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 150px">
    3030    <div style="width: 100px"></div>
    31     <div style="overflow-y: scroll; position: relative; z-index: 1"></div>
     31    <div style="overflow-y: scroll"></div>
    3232    <div style="width: 10px; position: relative; z-index: -1"></div>
    3333</div>
    … …  
    3535<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 0; left: 300px">
    3636    <div style="width: 100px"></div>
    37     <div style="overflow-y: scroll; position: relative; z-index: 1"></div>
     37    <div style="overflow-y: scroll"></div>
    3838    <div style="width: 10px; position: relative; z-index: -1"></div>
    3939</div>
    … …  
    4141<div class="testcase" style="top: 0; left: 450px">
    4242    <div style="width: 100px; height: 50px"></div>
    43     <div style="width: 100px; overflow-x: scroll; position: relative; z-index: 1"></div>
     43    <div style="width: 100px; overflow-x: scroll"></div>
    4444    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    4545</div>
    … …  
    4747<div class="testcase" style="top: 100px; left: 0">
    4848    <div style="width: 100px; height: 50px; "></div>
    49     <div style="width: 100px; overflow-x: scroll; position: relative; z-index: 1"></div>
     49    <div style="width: 100px; overflow-x: scroll"></div>
    5050    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    5151</div>
    5252
    5353<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 150px">
    54     <div style="width: 90px; overflow-y: scroll; position: relative; z-index: 1"></div>
     54    <div style="width: 90px; overflow-y: scroll"></div>
    5555    <div style="width: 10px; position: relative; z-index: -1"></div>
    5656</div>
    5757
    5858<div class="testcase" style="top: 100px; left: 300px">
    59     <div style="width: 100px; height: 40px; overflow-x: scroll; position: relative; z-index: 1"></div>
     59    <div style="width: 100px; height: 40px; overflow-x: scroll"></div>
    6060    <div style="width: 100px; height: 10px; position: relative; z-index: -1"></div>
    6161</div>
    … …  
    6363<div class="testcase" style="height: 50px; -webkit-writing-mode: vertical-lr; top: 100px; left: 450px">
    6464    <div style="width: 100px"></div>
    65     <div style="overflow-y: scroll; position: relative; z-index: 1"></div>
     65    <div style="overflow-y: scroll"></div>
    6666    <div style="width: 10px; position: relative; z-index: -1"></div>
    6767</div>

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r106376 r106378  
    40294029BUGWK77303 : fast/js/reserved-words-strict.html = TEXT
    40304030BUGWK77303 : fast/js/keywords-and-reserved_words.html = TEXT
    4031 BUGWK77309 WIN : css3/flexbox/cross-axis-scrollbar.html = IMAGE
    40324031
    40334032BUGWK77310 : fast/js/navigator-language.html = PASS TEXT
Note: See TracChangeset for help on using the changeset viewer.