Changeset 106388 in webkit

Timestamp:

Jan 31, 2012 1:43:56 PM (12 years ago)

Author:

jonlee@apple.com

Message:

Hidden form elements do not save their state prior to form submission
​https://bugs.webkit.org/show_bug.cgi?id=77391
<rdar://problem/10563108>

Reviewed by Brady Eidson.

Source/WebCore:

Test: fast/forms/state-restore-hidden.html

• html/HiddenInputType.cpp: Teach hidden inputs to save and restore their state.

(WebCore::HiddenInputType::saveFormControlState):
(WebCore::HiddenInputType::restoreFormControlState):

• html/HiddenInputType.h:

(HiddenInputType):

LayoutTests:

The test changes the value of the hidden input element via Javascript prior to
submitting the form. The form action goes back one page, and we check to see
that the hidden input value is what it was set to by Javascript, rather than what
it was originally assigned.

• fast/forms/state-restore-hidden-expected.txt: Added.
• fast/forms/state-restore-hidden.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/state-restore-hidden-expected.txt (added)
• LayoutTests/fast/forms/state-restore-hidden.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HiddenInputType.cpp (modified) (1 diff)
• Source/WebCore/html/HiddenInputType.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-31  Jon Lee  <jonlee@apple.com>
+
+        Hidden form elements do not save their state prior to form submission
+        https://bugs.webkit.org/show_bug.cgi?id=77391
+        <rdar://problem/10563108>
+
+        Reviewed by Brady Eidson.
+
+        The test changes the value of the hidden input element via Javascript prior to
+        submitting the form. The form action goes back one page, and we check to see
+        that the hidden input value is what it was set to by Javascript, rather than what
+        it was originally assigned.
+
+        * fast/forms/state-restore-hidden-expected.txt: Added.
+        * fast/forms/state-restore-hidden.html: Added.
+
 2012-01-31  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-31  Jon Lee  <jonlee@apple.com>
+
+        Hidden form elements do not save their state prior to form submission
+        https://bugs.webkit.org/show_bug.cgi?id=77391
+        <rdar://problem/10563108>
+
+        Reviewed by Brady Eidson.
+
+        Test: fast/forms/state-restore-hidden.html
+
+        * html/HiddenInputType.cpp: Teach hidden inputs to save and restore their state.
+        (WebCore::HiddenInputType::saveFormControlState):
+        (WebCore::HiddenInputType::restoreFormControlState):
+        * html/HiddenInputType.h:
+        (HiddenInputType):
+
 2012-01-31  Joshua Bell  <jsbell@chromium.org>
 

trunk/Source/WebCore/html/HiddenInputType.cpp

@@ -47 +47 @@
 }
 
-const AtomicString& HiddenInputType::formControlType() const {
+const AtomicString& HiddenInputType::formControlType() const
+{
     return InputTypeNames::hidden();
+}
+
+bool HiddenInputType::saveFormControlState(String& result) const
+{
+    result = element()->value();
+    return true;
+}
+
+void HiddenInputType::restoreFormControlState(const String& string) const
+{
+    element()->setAttribute(valueAttr, string);
 }
 

trunk/Source/WebCore/html/HiddenInputType.h

@@ -43 +43 @@
     HiddenInputType(HTMLInputElement* element) : InputType(element) { }
     virtual const AtomicString& formControlType() const OVERRIDE;
+    virtual bool saveFormControlState(String&) const OVERRIDE;
+    virtual void restoreFormControlState(const String&) const OVERRIDE;
     virtual bool supportsValidation() const OVERRIDE;
     virtual RenderObject* createRenderer(RenderArena*, RenderStyle*) const OVERRIDE;