Changeset 106430 in webkit

Timestamp:

Jan 31, 2012 9:37:49 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

​https://bugs.webkit.org/show_bug.cgi?id=76801
Listboxes incorrectly display contents when cleared and then re-populated.

Whenever the number of items in the listbox is less than the size of listbox (number of visible items the listbox can accomodate),
we set the listbox scroll-offset to zero. The scroll-offset of the Scrollbar should also be set to 0 so that when the listbox is re-populated,
scrollbar position and the content inside the listbox are in sync.

Source/WebCore:

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-01-31
Reviewed by Andreas Kling.

Tests: fast/forms/listbox-clear-restore.html

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeLogicalHeight): Setting the scroll-offset of the Scrollbar to 0 when scrollbar is not needed.

LayoutTests:

Added test case.

Patch by Joe Thomas <​joethomas@motorola.com> on 2012-01-31
Reviewed by Andreas Kling.

• fast/forms/listbox-clear-restore-expected.html: Added.
• fast/forms/listbox-clear-restore.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/listbox-clear-restore-expected.html (added)
• LayoutTests/fast/forms/listbox-clear-restore.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderListBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-01-31  Joe Thomas  <joethomas@motorola.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=76801
+        Listboxes incorrectly display contents when cleared and then re-populated.
+
+        Whenever the number of items in the listbox is less than the size of listbox (number of visible items the listbox can accomodate),
+        we set the listbox scroll-offset to zero. The scroll-offset of the Scrollbar should also be set to 0 so that when the listbox is re-populated,
+        scrollbar position and the content inside the listbox are in sync.
+
+        Added test case.
+
+        Reviewed by Andreas Kling.
+
+        * fast/forms/listbox-clear-restore-expected.html: Added.
+        * fast/forms/listbox-clear-restore.html: Added.
+
 2012-01-31  Yuzo Fujishima  <yuzo@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-01-31  Joe Thomas  <joethomas@motorola.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=76801
+        Listboxes incorrectly display contents when cleared and then re-populated.
+
+        Whenever the number of items in the listbox is less than the size of listbox (number of visible items the listbox can accomodate),
+        we set the listbox scroll-offset to zero. The scroll-offset of the Scrollbar should also be set to 0 so that when the listbox is re-populated,
+        scrollbar position and the content inside the listbox are in sync.
+
+        Reviewed by Andreas Kling.
+
+        Tests: fast/forms/listbox-clear-restore.html
+
+        * rendering/RenderListBox.cpp:
+        (WebCore::RenderListBox::computeLogicalHeight): Setting the scroll-offset of the Scrollbar to 0 when scrollbar is not needed.
+
 2012-01-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Source/WebCore/rendering/RenderListBox.cpp

@@ -255 +255 @@
         m_vBar->setSteps(1, max(1, numVisibleItems() - 1), itemHeight);
         m_vBar->setProportion(numVisibleItems(), numItems());
-        if (!enabled)
+        if (!enabled) {
+            scrollToYOffsetWithoutAnimation(0);
             m_indexOffset = 0;
+        }
     }
 }