Changeset 106580 in webkit

Timestamp:

Feb 2, 2012 12:46:43 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Constant values to set "distanceModel" are undefined
​https://bugs.webkit.org/show_bug.cgi?id=74273

Patch by Raymond Toy <Raymond Toy> on 2012-02-02
Reviewed by Kenneth Russell.

Source/WebCore:

Tests: webaudio/distance-exponential.html

webaudio/distance-inverse.html
webaudio/distance-linear.html

• webaudio/AudioPannerNode.h: Define enum for the new constants

for the distance models.

• webaudio/AudioPannerNode.idl: Define matching constants for the

distance models.

LayoutTests:

• webaudio/distance-exponential-expected.txt: Added.
• webaudio/distance-exponential.html: Added.
• webaudio/distance-inverse-expected.txt: Added.
• webaudio/distance-inverse.html: Added.
• webaudio/distance-linear-expected.txt: Added.
• webaudio/distance-linear.html: Added.
• webaudio/resources/distance-model-testing.js: Added.

(createImpulseBuffer):
(linearDistance):
(exponentialDistance):
(inverseDistance):
(createGraph):
(startSources):
(equalPowerGain):
(checkDistanceResult.return.renderedBuffer):
(checkDistanceResult):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webaudio/distance-exponential-expected.txt (added)
• LayoutTests/webaudio/distance-exponential.html (added)
• LayoutTests/webaudio/distance-inverse-expected.txt (added)
• LayoutTests/webaudio/distance-inverse.html (added)
• LayoutTests/webaudio/distance-linear-expected.txt (added)
• LayoutTests/webaudio/distance-linear.html (added)
• LayoutTests/webaudio/resources/distance-model-testing.js (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/webaudio/AudioPannerNode.h (modified) (1 diff)
• Source/WebCore/webaudio/AudioPannerNode.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-02  Raymond Toy  <rtoy@google.com>
+
+        Constant values to set "distanceModel" are undefined
+        https://bugs.webkit.org/show_bug.cgi?id=74273
+
+        Reviewed by Kenneth Russell.
+
+        * webaudio/distance-exponential-expected.txt: Added.
+        * webaudio/distance-exponential.html: Added.
+        * webaudio/distance-inverse-expected.txt: Added.
+        * webaudio/distance-inverse.html: Added.
+        * webaudio/distance-linear-expected.txt: Added.
+        * webaudio/distance-linear.html: Added.
+        * webaudio/resources/distance-model-testing.js: Added.
+        (createImpulseBuffer):
+        (linearDistance):
+        (exponentialDistance):
+        (inverseDistance):
+        (createGraph):
+        (startSources):
+        (equalPowerGain):
+        (checkDistanceResult.return.renderedBuffer):
+        (checkDistanceResult):
+
 2012-02-02  Raymond Toy  <rtoy@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2012-02-02  Raymond Toy  <rtoy@google.com>
+
+        Constant values to set "distanceModel" are undefined
+        https://bugs.webkit.org/show_bug.cgi?id=74273
+
+        Reviewed by Kenneth Russell.
+
+        Tests: webaudio/distance-exponential.html
+               webaudio/distance-inverse.html
+               webaudio/distance-linear.html
+
+        * webaudio/AudioPannerNode.h: Define enum for the new constants
+        for the distance models.
+        * webaudio/AudioPannerNode.idl: Define matching constants for the
+        distance models.
+
 2012-02-02  Raymond Toy  <rtoy@google.com>
 

trunk/Source/WebCore/webaudio/AudioPannerNode.h

@@ -54 +54 @@
     };
 
+    // These must be defined as in the .idl file and must match those
+    // in the DistanceEffect class.
+    enum {
+        LINEAR_DISTANCE = 0,
+        INVERSE_DISTANCE = 1,
+        EXPONENTIAL_DISTANCE = 2,
+    };
+    
     static PassRefPtr<AudioPannerNode> create(AudioContext* context, float sampleRate)
     {

trunk/Source/WebCore/webaudio/AudioPannerNode.idl

@@ -33 +33 @@
         const unsigned short SOUNDFIELD = 2;
 
+        // Distance model
+        const unsigned short LINEAR_DISTANCE = 0;
+        const unsigned short INVERSE_DISTANCE = 1;
+        const unsigned short EXPONENTIAL_DISTANCE = 2;
+
         // Default model for stereo is HRTF 
         // FIXME: use unsigned short when glue generation supports it