Changeset 106600 in webkit

Timestamp:

Feb 2, 2012 3:42:26 PM (12 years ago)

Author:

benjamin@webkit.org

Message:

Running a Web Worker on about:blank crashes the interpreter
​https://bugs.webkit.org/show_bug.cgi?id=77593

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-02-02
Reviewed by Michael Saboff.

Source/JavaScriptCore:

The method Interpreter::execute() was crashing on empty programs because
the assumption is made the source is not null.

This patch shortcut the execution when the String is null to avoid invalid
memory access.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

LayoutTests:

The Worker thread should not crash if running on an empty page.
The timer is necessary to give a chance for the thread to start.

• fast/workers/empty-worker-nocrash-expected.txt: Added.
• fast/workers/empty-worker-nocrash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/workers/empty-worker-nocrash-expected.txt (added)
• LayoutTests/fast/workers/empty-worker-nocrash.html (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/interpreter/Interpreter.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2012-02-02  Benjamin Poulain  <bpoulain@apple.com>
+
+        Running a Web Worker on about:blank crashes the interpreter
+        https://bugs.webkit.org/show_bug.cgi?id=77593
+
+        Reviewed by Michael Saboff.
+
+        The Worker thread should not crash if running on an empty page.
+        The timer is necessary to give a chance for the thread to start.
+
+        * fast/workers/empty-worker-nocrash-expected.txt: Added.
+        * fast/workers/empty-worker-nocrash.html: Added.
+
 2012-02-02  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2012-02-02  Benjamin Poulain  <bpoulain@apple.com>
+
+        Running a Web Worker on about:blank crashes the interpreter
+        https://bugs.webkit.org/show_bug.cgi?id=77593
+
+        Reviewed by Michael Saboff.
+
+        The method Interpreter::execute() was crashing on empty programs because
+        the assumption is made the source is not null.
+
+        This patch shortcut the execution when the String is null to avoid invalid
+        memory access.
+
+        * interpreter/Interpreter.cpp:
+        (JSC::Interpreter::execute):
+
 2012-02-02  Kalev Lember  <kalevlember@gmail.com>
 

trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

@@ -886 +886 @@
     bool parseResult;
     const UString programSource = program->source().toString();
+    if (programSource.isNull())
+        return jsUndefined();
     if (programSource.is8Bit()) {
         LiteralParser<LChar> literalParser(callFrame, programSource.characters8(), programSource.length(), JSONP);