Changeset 106644 in webkit
- Timestamp:
- Feb 3, 2012 3:02:22 AM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 21 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r106643 r106644 1 2012-02-03 Kentaro Hara <haraken@chromium.org> 2 3 Rename [InitializedByConstructor] IDL to [InitializedByEventConstructor] IDL 4 https://bugs.webkit.org/show_bug.cgi?id=77711 5 6 Reviewed by Adam Barth. 7 8 [InitializedByConstructor] can be used only when [ConstructorTemplate=Event] 9 is specified on the interface. This patch renames [InitializedByConstructor] to 10 [InitializedByEventConstructor] for clarification. 11 12 No tests. No change in behavior. 13 14 * bindings/scripts/CodeGeneratorJS.pm: 15 (GenerateConstructorDefinition): 16 * bindings/scripts/CodeGeneratorV8.pm: 17 (GenerateEventConstructorCallback): 18 19 * bindings/scripts/test/TestEventConstructor.idl: 20 * bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated the run-bindings-tests results. 21 (WebCore): 22 23 * dom/BeforeLoadEvent.idl: 24 * dom/CustomEvent.idl: 25 * dom/ErrorEvent.idl: 26 * dom/Event.idl: 27 * dom/HashChangeEvent.idl: 28 * dom/MessageEvent.idl: 29 * dom/OverflowEvent.idl: 30 * dom/PageTransitionEvent.idl: 31 * dom/PopStateEvent.idl: 32 * dom/ProgressEvent.idl: 33 * dom/WebKitAnimationEvent.idl: 34 * dom/WebKitTransitionEvent.idl: 35 * html/canvas/WebGLContextEvent.idl: 36 * html/track/TrackEvent.idl: 37 * storage/StorageEvent.idl: 38 * websockets/CloseEvent.idl: 39 1 40 2012-02-03 Kentaro Hara <haraken@chromium.org> 2 41 -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
r106639 r106644 3494 3494 for (my $index = 0; $index < @{$dataNode->attributes}; $index++) { 3495 3495 my $attribute = @{$dataNode->attributes}[$index]; 3496 if ($attribute->signature->extendedAttributes->{"InitializedBy Constructor"}) {3496 if ($attribute->signature->extendedAttributes->{"InitializedByEventConstructor"}) { 3497 3497 my $attributeName = $attribute->signature->name; 3498 3498 push(@implContent, <<END); -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
r106618 r106644 1752 1752 for (my $index = 0; $index < @{$dataNode->attributes}; $index++) { 1753 1753 my $attribute = @{$dataNode->attributes}[$index]; 1754 if ($attribute->signature->extendedAttributes->{"InitializedBy Constructor"}) {1754 if ($attribute->signature->extendedAttributes->{"InitializedByEventConstructor"}) { 1755 1755 my $attributeName = $attribute->signature->name; 1756 1756 push(@implContent, " options.get(\"$attributeName\", eventInit.$attributeName);\n"); -
trunk/Source/WebCore/bindings/scripts/test/TestEventConstructor.idl
r104526 r106644 35 35 // Attributes 36 36 readonly attribute DOMString attr1; 37 readonly attribute [InitializedBy Constructor] DOMString attr2;37 readonly attribute [InitializedByEventConstructor] DOMString attr2; 38 38 }; 39 39 } -
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp
r104526 r106644 59 59 // Attribute 'attr1' (Type: 'readonly attribute' ExtAttr: '') 60 60 {"attr1", TestEventConstructorInternal::attr1AttrGetter, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */}, 61 // Attribute 'attr2' (Type: 'readonly attribute' ExtAttr: 'InitializedBy Constructor')61 // Attribute 'attr2' (Type: 'readonly attribute' ExtAttr: 'InitializedByEventConstructor') 62 62 {"attr2", TestEventConstructorInternal::attr2AttrGetter, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */}, 63 63 }; -
trunk/Source/WebCore/dom/BeforeLoadEvent.idl
r100564 r106644 30 30 ConstructorTemplate=Event 31 31 ] BeforeLoadEvent : Event { 32 readonly attribute [InitializedBy Constructor] DOMString url;32 readonly attribute [InitializedByEventConstructor] DOMString url; 33 33 }; 34 34 -
trunk/Source/WebCore/dom/CustomEvent.idl
r100564 r106644 31 31 ConstructorTemplate=Event 32 32 ] CustomEvent : Event { 33 readonly attribute [InitializedBy Constructor] DOMObject detail;33 readonly attribute [InitializedByEventConstructor] DOMObject detail; 34 34 35 35 void initCustomEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, -
trunk/Source/WebCore/dom/ErrorEvent.idl
r100564 r106644 35 35 ConstructorTemplate=Event 36 36 ] ErrorEvent : Event { 37 readonly attribute [InitializedBy Constructor] DOMString message;38 readonly attribute [InitializedBy Constructor] DOMString filename;39 readonly attribute [InitializedBy Constructor] unsigned long lineno;37 readonly attribute [InitializedByEventConstructor] DOMString message; 38 readonly attribute [InitializedByEventConstructor] DOMString filename; 39 readonly attribute [InitializedByEventConstructor] unsigned long lineno; 40 40 }; 41 41 -
trunk/Source/WebCore/dom/Event.idl
r100564 r106644 58 58 readonly attribute EventTarget currentTarget; 59 59 readonly attribute unsigned short eventPhase; 60 readonly attribute [InitializedBy Constructor] boolean bubbles;61 readonly attribute [InitializedBy Constructor] boolean cancelable;60 readonly attribute [InitializedByEventConstructor] boolean bubbles; 61 readonly attribute [InitializedByEventConstructor] boolean cancelable; 62 62 readonly attribute DOMTimeStamp timeStamp; 63 63 -
trunk/Source/WebCore/dom/HashChangeEvent.idl
r100564 r106644 29 29 in [Optional=CallWithDefaultValue] DOMString oldURL, 30 30 in [Optional=CallWithDefaultValue] DOMString newURL); 31 readonly attribute [InitializedBy Constructor] DOMString oldURL;32 readonly attribute [InitializedBy Constructor] DOMString newURL;31 readonly attribute [InitializedByEventConstructor] DOMString oldURL; 32 readonly attribute [InitializedByEventConstructor] DOMString newURL; 33 33 }; 34 34 -
trunk/Source/WebCore/dom/MessageEvent.idl
r100564 r106644 32 32 ConstructorTemplate=Event 33 33 ] MessageEvent : Event { 34 readonly attribute [InitializedBy Constructor] DOMString origin;35 readonly attribute [InitializedBy Constructor] DOMString lastEventId;36 readonly attribute [InitializedBy Constructor] DOMWindow source;34 readonly attribute [InitializedByEventConstructor] DOMString origin; 35 readonly attribute [InitializedByEventConstructor] DOMString lastEventId; 36 readonly attribute [InitializedByEventConstructor] DOMWindow source; 37 37 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT 38 readonly attribute [InitializedBy Constructor, CachedAttribute, CustomGetter] DOMObject data;39 readonly attribute [InitializedBy Constructor, CustomGetter] Array ports;38 readonly attribute [InitializedByEventConstructor, CachedAttribute, CustomGetter] DOMObject data; 39 readonly attribute [InitializedByEventConstructor, CustomGetter] Array ports; 40 40 41 41 [Custom] void initMessageEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, -
trunk/Source/WebCore/dom/OverflowEvent.idl
r100564 r106644 33 33 const unsigned short BOTH = 2; 34 34 35 readonly attribute [InitializedBy Constructor] unsigned short orient;36 readonly attribute [InitializedBy Constructor] boolean horizontalOverflow;37 readonly attribute [InitializedBy Constructor] boolean verticalOverflow;35 readonly attribute [InitializedByEventConstructor] unsigned short orient; 36 readonly attribute [InitializedByEventConstructor] boolean horizontalOverflow; 37 readonly attribute [InitializedByEventConstructor] boolean verticalOverflow; 38 38 39 39 #if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C -
trunk/Source/WebCore/dom/PageTransitionEvent.idl
r100564 r106644 29 29 ConstructorTemplate=Event 30 30 ] PageTransitionEvent : Event { 31 readonly attribute [InitializedBy Constructor] boolean persisted;31 readonly attribute [InitializedByEventConstructor] boolean persisted; 32 32 }; 33 33 -
trunk/Source/WebCore/dom/PopStateEvent.idl
r100564 r106644 31 31 ConstructorTemplate=Event 32 32 ] PopStateEvent : Event { 33 readonly attribute [InitializedBy Constructor, CustomGetter] DOMObject state;33 readonly attribute [InitializedByEventConstructor, CustomGetter] DOMObject state; 34 34 }; 35 35 #endif -
trunk/Source/WebCore/dom/ProgressEvent.idl
r100727 r106644 29 29 ConstructorTemplate=Event 30 30 ] ProgressEvent : Event { 31 readonly attribute [InitializedBy Constructor] boolean lengthComputable;32 readonly attribute [InitializedBy Constructor] unsigned long long loaded;33 readonly attribute [InitializedBy Constructor] unsigned long long total;31 readonly attribute [InitializedByEventConstructor] boolean lengthComputable; 32 readonly attribute [InitializedByEventConstructor] unsigned long long loaded; 33 readonly attribute [InitializedByEventConstructor] unsigned long long total; 34 34 }; 35 35 -
trunk/Source/WebCore/dom/WebKitAnimationEvent.idl
r103751 r106644 29 29 ConstructorTemplate=Event 30 30 ] WebKitAnimationEvent : Event { 31 readonly attribute [InitializedBy Constructor] DOMString animationName;32 readonly attribute [InitializedBy Constructor] double elapsedTime;31 readonly attribute [InitializedByEventConstructor] DOMString animationName; 32 readonly attribute [InitializedByEventConstructor] double elapsedTime; 33 33 }; 34 34 -
trunk/Source/WebCore/dom/WebKitTransitionEvent.idl
r103746 r106644 29 29 ConstructorTemplate=Event 30 30 ] WebKitTransitionEvent : Event { 31 readonly attribute [InitializedBy Constructor] DOMString propertyName;32 readonly attribute [InitializedBy Constructor] double elapsedTime;31 readonly attribute [InitializedByEventConstructor] DOMString propertyName; 32 readonly attribute [InitializedByEventConstructor] double elapsedTime; 33 33 }; 34 34 -
trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl
r101183 r106644 30 30 ConstructorTemplate=Event 31 31 ] WebGLContextEvent : Event { 32 readonly attribute [InitializedBy Constructor] DOMString statusMessage;32 readonly attribute [InitializedByEventConstructor] DOMString statusMessage; 33 33 }; 34 34 -
trunk/Source/WebCore/html/track/TrackEvent.idl
r100564 r106644 31 31 ConstructorTemplate=Event 32 32 ] TrackEvent : Event { 33 readonly attribute [InitializedBy Constructor, CustomGetter] object track;33 readonly attribute [InitializedByEventConstructor, CustomGetter] object track; 34 34 }; 35 35 -
trunk/Source/WebCore/storage/StorageEvent.idl
r106534 r106644 29 29 ConstructorTemplate=Event 30 30 ] StorageEvent : Event { 31 readonly attribute [InitializedBy Constructor] DOMString key;32 readonly attribute [InitializedBy Constructor, ConvertNullStringTo=Null] DOMString oldValue;33 readonly attribute [InitializedBy Constructor, ConvertNullStringTo=Null] DOMString newValue;34 readonly attribute [InitializedBy Constructor] DOMString url;35 readonly attribute [InitializedBy Constructor] Storage storageArea;31 readonly attribute [InitializedByEventConstructor] DOMString key; 32 readonly attribute [InitializedByEventConstructor, ConvertNullStringTo=Null] DOMString oldValue; 33 readonly attribute [InitializedByEventConstructor, ConvertNullStringTo=Null] DOMString newValue; 34 readonly attribute [InitializedByEventConstructor] DOMString url; 35 readonly attribute [InitializedByEventConstructor] Storage storageArea; 36 36 37 37 void initStorageEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, -
trunk/Source/WebCore/websockets/CloseEvent.idl
r100564 r106644 35 35 ConstructorTemplate=Event 36 36 ] CloseEvent : Event { 37 readonly attribute [InitializedBy Constructor] boolean wasClean;38 readonly attribute [InitializedBy Constructor] unsigned short code;39 readonly attribute [InitializedBy Constructor, ConvertingNullStringTo=Undefined] DOMString reason;37 readonly attribute [InitializedByEventConstructor] boolean wasClean; 38 readonly attribute [InitializedByEventConstructor] unsigned short code; 39 readonly attribute [InitializedByEventConstructor, ConvertingNullStringTo=Undefined] DOMString reason; 40 40 }; 41 41
Note: See TracChangeset
for help on using the changeset viewer.