Changeset 106644 in webkit


Ignore:
Timestamp:
Feb 3, 2012 3:02:22 AM (12 years ago)
Author:
haraken@chromium.org
Message:

Rename [InitializedByConstructor] IDL to [InitializedByEventConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=77711

Reviewed by Adam Barth.

[InitializedByConstructor] can be used only when [ConstructorTemplate=Event]
is specified on the interface. This patch renames [InitializedByConstructor] to
[InitializedByEventConstructor] for clarification.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):

  • bindings/scripts/test/TestEventConstructor.idl:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated the run-bindings-tests results.

(WebCore):

  • dom/BeforeLoadEvent.idl:
  • dom/CustomEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/MessageEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitTransitionEvent.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/track/TrackEvent.idl:
  • storage/StorageEvent.idl:
  • websockets/CloseEvent.idl:
Location:
trunk/Source/WebCore
Files:
21 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r106643 r106644  
     12012-02-03  Kentaro Hara  <haraken@chromium.org>
     2
     3        Rename [InitializedByConstructor] IDL to [InitializedByEventConstructor] IDL
     4        https://bugs.webkit.org/show_bug.cgi?id=77711
     5
     6        Reviewed by Adam Barth.
     7
     8        [InitializedByConstructor] can be used only when [ConstructorTemplate=Event]
     9        is specified on the interface. This patch renames [InitializedByConstructor] to
     10        [InitializedByEventConstructor] for clarification.
     11
     12        No tests. No change in behavior.
     13
     14        * bindings/scripts/CodeGeneratorJS.pm:
     15        (GenerateConstructorDefinition):
     16        * bindings/scripts/CodeGeneratorV8.pm:
     17        (GenerateEventConstructorCallback):
     18
     19        * bindings/scripts/test/TestEventConstructor.idl:
     20        * bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated the run-bindings-tests results.
     21        (WebCore):
     22
     23        * dom/BeforeLoadEvent.idl:
     24        * dom/CustomEvent.idl:
     25        * dom/ErrorEvent.idl:
     26        * dom/Event.idl:
     27        * dom/HashChangeEvent.idl:
     28        * dom/MessageEvent.idl:
     29        * dom/OverflowEvent.idl:
     30        * dom/PageTransitionEvent.idl:
     31        * dom/PopStateEvent.idl:
     32        * dom/ProgressEvent.idl:
     33        * dom/WebKitAnimationEvent.idl:
     34        * dom/WebKitTransitionEvent.idl:
     35        * html/canvas/WebGLContextEvent.idl:
     36        * html/track/TrackEvent.idl:
     37        * storage/StorageEvent.idl:
     38        * websockets/CloseEvent.idl:
     39
    1402012-02-03  Kentaro Hara  <haraken@chromium.org>
    241
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r106639 r106644  
    34943494            for (my $index = 0; $index < @{$dataNode->attributes}; $index++) {
    34953495                my $attribute = @{$dataNode->attributes}[$index];
    3496                 if ($attribute->signature->extendedAttributes->{"InitializedByConstructor"}) {
     3496                if ($attribute->signature->extendedAttributes->{"InitializedByEventConstructor"}) {
    34973497                    my $attributeName = $attribute->signature->name;
    34983498                    push(@implContent, <<END);
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r106618 r106644  
    17521752    for (my $index = 0; $index < @{$dataNode->attributes}; $index++) {
    17531753        my $attribute = @{$dataNode->attributes}[$index];
    1754         if ($attribute->signature->extendedAttributes->{"InitializedByConstructor"}) {
     1754        if ($attribute->signature->extendedAttributes->{"InitializedByEventConstructor"}) {
    17551755            my $attributeName = $attribute->signature->name;
    17561756            push(@implContent, "    options.get(\"$attributeName\", eventInit.$attributeName);\n");
  • trunk/Source/WebCore/bindings/scripts/test/TestEventConstructor.idl

    r104526 r106644  
    3535        // Attributes
    3636        readonly attribute DOMString attr1;
    37         readonly attribute [InitializedByConstructor] DOMString attr2;
     37        readonly attribute [InitializedByEventConstructor] DOMString attr2;
    3838    };
    3939}
  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestEventConstructor.cpp

    r104526 r106644  
    5959    // Attribute 'attr1' (Type: 'readonly attribute' ExtAttr: '')
    6060    {"attr1", TestEventConstructorInternal::attr1AttrGetter, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
    61     // Attribute 'attr2' (Type: 'readonly attribute' ExtAttr: 'InitializedByConstructor')
     61    // Attribute 'attr2' (Type: 'readonly attribute' ExtAttr: 'InitializedByEventConstructor')
    6262    {"attr2", TestEventConstructorInternal::attr2AttrGetter, 0, 0 /* no data */, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
    6363};
  • trunk/Source/WebCore/dom/BeforeLoadEvent.idl

    r100564 r106644  
    3030        ConstructorTemplate=Event
    3131    ] BeforeLoadEvent : Event {
    32         readonly attribute [InitializedByConstructor] DOMString url;
     32        readonly attribute [InitializedByEventConstructor] DOMString url;
    3333    };
    3434
  • trunk/Source/WebCore/dom/CustomEvent.idl

    r100564 r106644  
    3131        ConstructorTemplate=Event
    3232    ] CustomEvent : Event {
    33         readonly attribute [InitializedByConstructor] DOMObject detail;
     33        readonly attribute [InitializedByEventConstructor] DOMObject detail;
    3434
    3535        void initCustomEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
  • trunk/Source/WebCore/dom/ErrorEvent.idl

    r100564 r106644  
    3535        ConstructorTemplate=Event
    3636    ] ErrorEvent : Event {
    37         readonly attribute [InitializedByConstructor] DOMString message;
    38         readonly attribute [InitializedByConstructor] DOMString filename;
    39         readonly attribute [InitializedByConstructor] unsigned long lineno;
     37        readonly attribute [InitializedByEventConstructor] DOMString message;
     38        readonly attribute [InitializedByEventConstructor] DOMString filename;
     39        readonly attribute [InitializedByEventConstructor] unsigned long lineno;
    4040    };
    4141
  • trunk/Source/WebCore/dom/Event.idl

    r100564 r106644  
    5858        readonly attribute EventTarget      currentTarget;
    5959        readonly attribute unsigned short   eventPhase;
    60         readonly attribute [InitializedByConstructor] boolean bubbles;
    61         readonly attribute [InitializedByConstructor] boolean cancelable;
     60        readonly attribute [InitializedByEventConstructor] boolean bubbles;
     61        readonly attribute [InitializedByEventConstructor] boolean cancelable;
    6262        readonly attribute DOMTimeStamp     timeStamp;
    6363
  • trunk/Source/WebCore/dom/HashChangeEvent.idl

    r100564 r106644  
    2929                                 in [Optional=CallWithDefaultValue] DOMString oldURL,
    3030                                 in [Optional=CallWithDefaultValue] DOMString newURL);
    31         readonly attribute [InitializedByConstructor] DOMString oldURL;
    32         readonly attribute [InitializedByConstructor] DOMString newURL;
     31        readonly attribute [InitializedByEventConstructor] DOMString oldURL;
     32        readonly attribute [InitializedByEventConstructor] DOMString newURL;
    3333    };
    3434
  • trunk/Source/WebCore/dom/MessageEvent.idl

    r100564 r106644  
    3232        ConstructorTemplate=Event
    3333    ] MessageEvent : Event {
    34         readonly attribute [InitializedByConstructor] DOMString origin;
    35         readonly attribute [InitializedByConstructor] DOMString lastEventId;
    36         readonly attribute [InitializedByConstructor] DOMWindow source;
     34        readonly attribute [InitializedByEventConstructor] DOMString origin;
     35        readonly attribute [InitializedByEventConstructor] DOMString lastEventId;
     36        readonly attribute [InitializedByEventConstructor] DOMWindow source;
    3737#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
    38         readonly attribute [InitializedByConstructor, CachedAttribute, CustomGetter] DOMObject data;
    39         readonly attribute [InitializedByConstructor, CustomGetter] Array ports;
     38        readonly attribute [InitializedByEventConstructor, CachedAttribute, CustomGetter] DOMObject data;
     39        readonly attribute [InitializedByEventConstructor, CustomGetter] Array ports;
    4040
    4141        [Custom] void initMessageEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
  • trunk/Source/WebCore/dom/OverflowEvent.idl

    r100564 r106644  
    3333        const unsigned short BOTH       = 2;
    3434       
    35         readonly attribute [InitializedByConstructor] unsigned short orient;
    36         readonly attribute [InitializedByConstructor] boolean horizontalOverflow;
    37         readonly attribute [InitializedByConstructor] boolean verticalOverflow;
     35        readonly attribute [InitializedByEventConstructor] unsigned short orient;
     36        readonly attribute [InitializedByEventConstructor] boolean horizontalOverflow;
     37        readonly attribute [InitializedByEventConstructor] boolean verticalOverflow;
    3838
    3939#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
  • trunk/Source/WebCore/dom/PageTransitionEvent.idl

    r100564 r106644  
    2929        ConstructorTemplate=Event
    3030    ] PageTransitionEvent : Event {
    31         readonly attribute [InitializedByConstructor] boolean persisted;
     31        readonly attribute [InitializedByEventConstructor] boolean persisted;
    3232    };
    3333
  • trunk/Source/WebCore/dom/PopStateEvent.idl

    r100564 r106644  
    3131        ConstructorTemplate=Event
    3232    ] PopStateEvent : Event {
    33         readonly attribute [InitializedByConstructor, CustomGetter] DOMObject state;
     33        readonly attribute [InitializedByEventConstructor, CustomGetter] DOMObject state;
    3434    };
    3535#endif
  • trunk/Source/WebCore/dom/ProgressEvent.idl

    r100727 r106644  
    2929        ConstructorTemplate=Event
    3030    ] ProgressEvent : Event {
    31         readonly attribute [InitializedByConstructor] boolean lengthComputable;
    32         readonly attribute [InitializedByConstructor] unsigned long long loaded;
    33         readonly attribute [InitializedByConstructor] unsigned long long total;
     31        readonly attribute [InitializedByEventConstructor] boolean lengthComputable;
     32        readonly attribute [InitializedByEventConstructor] unsigned long long loaded;
     33        readonly attribute [InitializedByEventConstructor] unsigned long long total;
    3434    };
    3535
  • trunk/Source/WebCore/dom/WebKitAnimationEvent.idl

    r103751 r106644  
    2929        ConstructorTemplate=Event
    3030    ] WebKitAnimationEvent : Event {
    31         readonly attribute [InitializedByConstructor] DOMString animationName;
    32         readonly attribute [InitializedByConstructor] double elapsedTime;
     31        readonly attribute [InitializedByEventConstructor] DOMString animationName;
     32        readonly attribute [InitializedByEventConstructor] double elapsedTime;
    3333};
    3434
  • trunk/Source/WebCore/dom/WebKitTransitionEvent.idl

    r103746 r106644  
    2929        ConstructorTemplate=Event
    3030    ] WebKitTransitionEvent : Event {
    31         readonly attribute [InitializedByConstructor] DOMString propertyName;
    32         readonly attribute [InitializedByConstructor] double elapsedTime;
     31        readonly attribute [InitializedByEventConstructor] DOMString propertyName;
     32        readonly attribute [InitializedByEventConstructor] double elapsedTime;
    3333    };
    3434
  • trunk/Source/WebCore/html/canvas/WebGLContextEvent.idl

    r101183 r106644  
    3030        ConstructorTemplate=Event
    3131    ] WebGLContextEvent : Event {
    32         readonly attribute [InitializedByConstructor] DOMString statusMessage;
     32        readonly attribute [InitializedByEventConstructor] DOMString statusMessage;
    3333    };
    3434
  • trunk/Source/WebCore/html/track/TrackEvent.idl

    r100564 r106644  
    3131        ConstructorTemplate=Event
    3232    ] TrackEvent : Event {
    33         readonly attribute [InitializedByConstructor, CustomGetter] object track;
     33        readonly attribute [InitializedByEventConstructor, CustomGetter] object track;
    3434    };
    3535
  • trunk/Source/WebCore/storage/StorageEvent.idl

    r106534 r106644  
    2929        ConstructorTemplate=Event
    3030    ] StorageEvent : Event {
    31         readonly attribute [InitializedByConstructor] DOMString key;
    32         readonly attribute [InitializedByConstructor, ConvertNullStringTo=Null] DOMString oldValue;
    33         readonly attribute [InitializedByConstructor, ConvertNullStringTo=Null] DOMString newValue;
    34         readonly attribute [InitializedByConstructor] DOMString url;
    35         readonly attribute [InitializedByConstructor] Storage storageArea;
     31        readonly attribute [InitializedByEventConstructor] DOMString key;
     32        readonly attribute [InitializedByEventConstructor, ConvertNullStringTo=Null] DOMString oldValue;
     33        readonly attribute [InitializedByEventConstructor, ConvertNullStringTo=Null] DOMString newValue;
     34        readonly attribute [InitializedByEventConstructor] DOMString url;
     35        readonly attribute [InitializedByEventConstructor] Storage storageArea;
    3636
    3737        void initStorageEvent(in [Optional=CallWithDefaultValue] DOMString typeArg,
  • trunk/Source/WebCore/websockets/CloseEvent.idl

    r100564 r106644  
    3535        ConstructorTemplate=Event
    3636    ] CloseEvent : Event {
    37         readonly attribute [InitializedByConstructor] boolean wasClean;
    38         readonly attribute [InitializedByConstructor] unsigned short code;
    39         readonly attribute [InitializedByConstructor, ConvertingNullStringTo=Undefined] DOMString reason;
     37        readonly attribute [InitializedByEventConstructor] boolean wasClean;
     38        readonly attribute [InitializedByEventConstructor] unsigned short code;
     39        readonly attribute [InitializedByEventConstructor, ConvertingNullStringTo=Undefined] DOMString reason;
    4040    };
    4141
Note: See TracChangeset for help on using the changeset viewer.