Changeset 106713 in webkit


Ignore:
Timestamp:
Feb 3, 2012 5:18:23 PM (12 years ago)
Author:
abarth@webkit.org
Message:

Add a blank "Expected Failures" tab to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=77793

Reviewed by Eric Seidel.

This tab will help us explore and manage our expected failures. The
tab is hidden by default via a new "experimental features" flag.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:

(#unexpected):
(#onebar.partytime #unexpected):

Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js

    r105663 r106713  
    7070config.kRelativeTimeUpdateFrequency = 1000 * 60;
    7171
    72 
     72config.kExperimentalFeatures = window.location.search.search('enableExperiments=1') != -1;
    7373
    7474})();
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js

    r105530 r106713  
    100100    updateButton.textContent = 'update';
    101101
    102     var summary = onebar.summary();
    103     summary.appendChild(updateButton);
    104     summary.appendChild(g_info);
    105     summary.appendChild(unexpectedFailuresView);
     102    var unexpected = onebar.unexpected();
     103    unexpected.appendChild(updateButton);
     104    unexpected.appendChild(g_info);
     105    unexpected.appendChild(unexpectedFailuresView);
     106
     107    var expected = onebar.expected();
     108    if (expected) {
     109        var expectedFailuresView = new ui.failures.List();
     110        expected.appendChild(expectedFailuresView);
     111    }
    106112
    107113    update();
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js

    r97172 r106713  
    6464        this.innerHTML =
    6565            '<ul>' +
    66                 '<li><a href="#summary">Summary</a></li>' +
     66                '<li><a href="#unexpected">Unexpected Failures</a></li>' +
     67                '<li><a href="#expected">Expected Failures</a></li>' +
    6768                '<li><a href="#results">Results</a></li>' +
    6869            '</ul>' +
    69             '<div id="summary"></div>' +
     70            '<div id="unexpected"></div>' +
     71            '<div id="expected"></div>' +
    7072            '<div id="results"></div>';
    7173        this._tabNames = [
    72             'summary',
     74            'unexpected',
     75            'expected',
    7376            'results',
    7477        ]
    7578        this._tabs = $(this).tabs({
    76             disabled: [1],
     79            disabled: [2],
    7780        });
     81        if (!config.kExperimentalFeatures)
     82            this._tabs.tabs('remove', 1);
    7883    },
    7984    attach: function()
     
    8489    {
    8590        tab = document.getElementById(tabName);
     91        if (!tab)
     92            return null;
    8693        // We perform this sanity check below to make sure getElementById
    8794        // hasn't given us a node in some other unrelated part of the document.
     
    9299        return tab;
    93100    },
    94     summary: function()
     101    unexpected: function()
    95102    {
    96         return this.tabNamed('summary');
     103        return this.tabNamed('unexpected');
     104    },
     105    expected: function()
     106    {
     107        return this.tabNamed('expected');
    97108    },
    98109    results: function()
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js

    r104423 r106713  
    128128});
    129129
     130ui.failures.List = base.extends('div', {
     131    init: function()
     132    {
     133        this.textContent = "TODO: List failures here.";
     134    }
     135});
     136
    130137})();
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css

    r105550 r106713  
    4141}
    4242
    43 #summary {
     43#unexpected {
    4444    min-height: 550px;
    4545}
    4646
    47 #onebar.partytime #summary {
     47#onebar.partytime #unexpected {
    4848    background: url(../images/partytime.gif) center center no-repeat;
    4949}
  • trunk/Tools/ChangeLog

    r106708 r106713  
     12012-02-03  Adam Barth  <abarth@webkit.org>
     2
     3        Add a blank "Expected Failures" tab to garden-o-matic
     4        https://bugs.webkit.org/show_bug.cgi?id=77793
     5
     6        Reviewed by Eric Seidel.
     7
     8        This tab will help us explore and manage our expected failures.  The
     9        tab is hidden by default via a new "experimental features" flag.
     10
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
     13        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
     14        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
     16        (#unexpected):
     17        (#onebar.partytime #unexpected):
     18
    1192012-02-03  Lucas Forschler  <lforschler@apple.com>
    220
Note: See TracChangeset for help on using the changeset viewer.