Changeset 106739 in webkit

Timestamp:

Feb 4, 2012 2:22:12 AM (12 years ago)

Author:

abarth@webkit.org

Message:

garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
​https://bugs.webkit.org/show_bug.cgi?id=77802

Reviewed by Eric Seidel.

This patch refactors our directory grouping code into base.js where it
can be shared between failures.js and notifications.js. It then adds
an Examine action to each group of failures that triggers the "results"
view.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js

@@ -172 +172 @@
 };
 
+base.forEachDirectory = function(pathList, callback)
+{
+    var pathsByDirectory = {};
+    pathList.forEach(function(path) {
+        var directory = base.dirName(path);
+        pathsByDirectory[directory] = pathsByDirectory[directory] || [];
+        pathsByDirectory[directory].push(path);
+    });
+    Object.keys(pathsByDirectory).sort().forEach(function(directory) {
+        var paths = pathsByDirectory[directory];
+        callback(directory + ' (' + paths.length + ' tests)', paths);
+    });
+};
+
 base.parseJSONP = function(jsonp)
 {
@@ -177 +191 @@
     var endIndex = jsonp.lastIndexOf(')');
     return JSON.parse(jsonp.substr(startIndex, endIndex - startIndex));
-}
+};
 
 base.RequestTracker = function(requestsInFlight, callback, args)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js

@@ -105 +105 @@
     {
         var expectedOrUnexpectedFailures = results.expectedOrUnexpectedFailuresByTest(this._model.resultsByBuilder);
-        this._view.setFailingTests(Object.keys(expectedOrUnexpectedFailures));
+        var failingTestsList = Object.keys(expectedOrUnexpectedFailures);
+
+        $(this._view).empty();
+        base.forEachDirectory(failingTestsList, function(label, testsFailingInDirectory) {
+            var listItem = new ui.failures.ListItem(label, testsFailingInDirectory);
+            this._view.appendChild(listItem);
+            $(listItem).bind('examine', function() {
+                this.onExamine(testsFailingInDirectory);
+            }.bind(this));
+        }.bind(this));
+    },
+    onExamine: function(failingTestsList)
+    {
+        var resultsView = new ui.results.View({
+            fetchResultsURLs: results.fetchResultsURLs
+        });
+        var failuresByTest = base.filterDictionary(
+            results.expectedOrUnexpectedFailuresByTest(this._model.resultsByBuilder),
+            function(key) {
+                return failingTestsList.indexOf(key) != -1;
+            });
+        var controller = new controllers.ResultsDetails(resultsView, failuresByTest);
+        this._delegate.showResults(resultsView);
     }
 });

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js

@@ -128 +128 @@
 });
 
-ui.failures.List = base.extends('div', {
+ui.failures.ListItem = base.extends('li', {
+    init: function(groupName, failingTestsList)
+    {
+        this._failingTestsList = failingTestsList;
+        this.appendChild(new ui.actions.List([
+            new ui.actions.Examine().makeDefault(),
+        ]));
+        var label = this.appendChild(document.createElement('label'))
+        label.textContent = failingTestsList.length == 1 ? failingTestsList[0] : groupName;
+    },
+});
+
+ui.failures.List = base.extends('ul', {
     init: function()
     {
+        this.className = 'failures';
         this.textContent = 'Loading...';
-    },
-    setFailingTests: function(failingTestsList)
-    {
-        $(this).empty();
-        var list = this.appendChild(document.createElement('ul'));
-        failingTestsList.sort().forEach(function(failingTest) {
-            list.appendChild(document.createElement('li')).textContent = failingTest;
-        });
     }
 });

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js

@@ -183 +183 @@
     _forEachTestGroup: function(callback)
     {
-        var testsByDirectory = {};
-        this._testNameList.forEach(function(testName) {
-            var directory = base.dirName(testName);
-            testsByDirectory[directory] = testsByDirectory[directory] || [];
-            testsByDirectory[directory].push(testName);
-        });
         var individualTests = [];
-        Object.keys(testsByDirectory).forEach(function(directory) {
-            var testsInDirectory = testsByDirectory[directory];
-            var count = testsInDirectory.length;
-            if (count <= kMaxTestsPerGroup) {
+        base.forEachDirectory(this._testNameList, function(groupLabel, testsInDirectory) {
+            if (testsInDirectory.length <= kMaxTestsPerGroup) {
                 individualTests = individualTests.concat(testsInDirectory);
                 return;
             }
-            callback(directory + ' (' + count + ' tests)', testsInDirectory);
+            callback(groupLabel, testsInDirectory);
         });
         individualTests.forEach(function(testName) {

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js

@@ -219 +219 @@
             '<div class="problem">' +
                 '<ul class="effects">' +
-                    '<li><a target="_blank" href="http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=test">test</a></li>' +
                     '<li><a target="_blank" href="http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=foo">foo</a></li>' +
+                    '<li><a target="_blank" href="http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=test">test</a></li>' +
                 '</ul>' +
                 '<ul class="actions">' +
@@ -264 +264 @@
             '<div class="problem">' +
                 '<ul class="effects">' +
-                    '<li><a target="_blank" href="http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=test">test</a></li>' +
                     '<li><a target="_blank" href="http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=foo">foo</a></li>' +
+                    '<li><a target="_blank" href="http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=test">test</a></li>' +
                 '</ul>' +
                 '<ul class="actions">' +

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css

@@ -52 +52 @@
         padding: 0 2px;
     }
+
+
+ul.failures {
+    padding: 0px;
+}
+
+    ul.failures>li {
+        display: -webkit-box;
+    }
+
+    ul.failures>li label {
+        margin-left: 10px;
+    }
+
+        ul.failures>li ul.actions {
+            padding: 0px;
+            visibility: hidden;
+        }
+
+        ul.failures>li:hover ul.actions {
+            visibility: visible;
+        }

trunk/Tools/ChangeLog

@@ +1 @@
+2012-02-04  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
+        https://bugs.webkit.org/show_bug.cgi?id=77802
+
+        Reviewed by Eric Seidel.
+
+        This patch refactors our directory grouping code into base.js where it
+        can be shared between failures.js and notifications.js.  It then adds
+        an Examine action to each group of failures that triggers the "results"
+        view.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
+
 2012-02-04  Ojan Vafai  <ojan@chromium.org>