Changeset 106755 in webkit


Ignore:
Timestamp:
Feb 5, 2012 12:27:07 AM (12 years ago)
Author:
loislo@chromium.org
Message:

Web Inspector: beautify retaining tree items view.
https://bugs.webkit.org/show_bug.cgi?id=77810

Reviewed by Yury Semikhatsky.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):

  • inspector/front-end/heapProfiler.css:

(.cycled-ancessor-node):

  • inspector/front-end/profilesPanel.css:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r106754 r106755  
     12012-02-05  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Web Inspector: beautify retaining tree items view.
     4        https://bugs.webkit.org/show_bug.cgi?id=77810
     5
     6        Reviewed by Yury Semikhatsky.
     7
     8        * inspector/front-end/DetailedHeapshotGridNodes.js:
     9        (WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
     10        (WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
     11        * inspector/front-end/heapProfiler.css:
     12        (.cycled-ancessor-node):
     13        * inspector/front-end/profilesPanel.css:
     14
    1152012-02-04  Shawn Singh  <shawnsingh@chromium.org>
    216
  • trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js

    r106738 r106755  
    240240        valueSpan.textContent = data.value;
    241241        div.appendChild(valueSpan);
    242         if (this._postfixObjectCell)
    243             this._postfixObjectCell(div, data);
    244242        cell.appendChild(div);
    245243        cell.addStyleClass("disclosure");
     
    459457            if (this._cycledWithAncestorGridNode)
    460458                div.className += " cycled-ancessor-node";
     459            var referenceNameSpan = document.createElement("span");
     460            referenceNameSpan.className = "name";
     461            referenceNameSpan.textContent = this._referenceName + " ";
     462            div.appendChild(referenceNameSpan);
     463
     464            var separatorSpan = document.createElement("span");
     465            separatorSpan.className = "separator";
     466            separatorSpan.textContent = " of ";
     467            div.appendChild(separatorSpan);
     468
    461469            return;
    462470        }
     
    471479        separatorSpan.textContent = ": ";
    472480        div.appendChild(separatorSpan);
    473     },
    474 
    475     _postfixObjectCell: function(div, data)
    476     {
    477         if (this._retainerNode) {
    478             var referenceTypeSpan = document.createElement("span");
    479             referenceTypeSpan.className = "console-formatted-object";
    480             referenceTypeSpan.textContent = this._propertyAccessor;
    481             div.appendChild(referenceTypeSpan);
    482         }
    483481    }
    484482}
  • trunk/Source/WebCore/inspector/front-end/heapProfiler.css

    r106633 r106755  
    221221    color: blue;
    222222}
     223
     224.cycled-ancessor-node {
     225    opacity: 0.6;
     226}
     227
  • trunk/Source/WebCore/inspector/front-end/profilesPanel.css

    r106738 r106755  
    175175}
    176176
    177 .cycled-ancessor-node {
    178     color: lightgray;
    179 }
    180 
    181177.panel-enabler-view.profile-launcher-view button:not(.status-bar-item) {
    182178    color: rgb(6, 6, 6);
Note: See TracChangeset for help on using the changeset viewer.