Changeset 106773 in webkit


Ignore:
Timestamp:
Feb 5, 2012 8:47:11 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Rename [JSCCustom*] IDL to [JSCustom*] IDL
​https://bugs.webkit.org/show_bug.cgi?id=77844

Reviewed by Adam Barth.

Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
[JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
[JSCustomSetter].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • css/CSSStyleDeclaration.idl:
  • html/HTMLDocument.idl:
  • html/canvas/DataView.idl:
  • page/DOMWindow.idl:
  • page/MemoryInfo.idl:
  • webaudio/ConvolverNode.idl:
  • webaudio/DOMWindowWebAudio.idl:
  • webaudio/WaveShaperNode.idl:
  • websockets/DOMWindowWebSocket.idl:
  • workers/WorkerContext.idl:
Location:
trunk/Source/WebCore
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r106772 r106773  
     12012-02-05  Kentaro Hara  <haraken@chromium.org>
     2
     3        Rename [JSCCustom*] IDL to [JSCustom*] IDL
     4        https://bugs.webkit.org/show_bug.cgi?id=77844
     5
     6        Reviewed by Adam Barth.
     7
     8        Most existing JSC-specific IDLs have "JS" prefix. We can rename [JSCCustom] to
     9        [JSCustom], [JSCCustomGetter] to [JSCustomGetter], and [JSCCustomSetter] to
     10        [JSCustomSetter].
     11
     12        No tests. No change in behavior.
     13
     14        * bindings/scripts/CodeGeneratorJS.pm:
     15        (GenerateHeader):
     16        (GenerateImplementation):
     17        * css/CSSStyleDeclaration.idl:
     18        * html/HTMLDocument.idl:
     19        * html/canvas/DataView.idl:
     20        * page/DOMWindow.idl:
     21        * page/MemoryInfo.idl:
     22        * webaudio/ConvolverNode.idl:
     23        * webaudio/DOMWindowWebAudio.idl:
     24        * webaudio/WaveShaperNode.idl:
     25        * websockets/DOMWindowWebSocket.idl:
     26        * workers/WorkerContext.idl:
     27
    1282012-02-05  ChangSeok Oh  <shivamidow@gmail.com>
    229

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r106737 r106773  
    858858        foreach (@{$dataNode->attributes}) {
    859859            my $attribute = $_;
    860             $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"};
    861             $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCCustomGetter"});
    862             $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCCustomSetter"});
     860            $numCustomAttributes++ if $attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"};
     861            $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCustomGetter"});
     862            $numCustomAttributes++ if ($attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCustomSetter"});
    863863            if ($attribute->signature->extendedAttributes->{"CachedAttribute"}) {
    864864                push(@headerContent, "    JSC::WriteBarrier<JSC::Unknown> m_" . $attribute->signature->name . ";\n");
    … …  
    879879
    880880        foreach my $attribute (@{$dataNode->attributes}) {
    881             if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCCustomGetter"}) {
     881            if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCustomGetter"}) {
    882882                my $methodName = $codeGenerator->WK_lcfirst($attribute->signature->name);
    883883                push(@headerContent, "    JSC::JSValue " . $methodName . "(JSC::ExecState*) const;\n");
    884884            }
    885             if (($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCCustomSetter"}) && $attribute->type !~ /^readonly/) {
     885            if (($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCustomSetter"}) && $attribute->type !~ /^readonly/) {
    886886                push(@headerContent, "    void set" . $codeGenerator->WK_ucfirst($attribute->signature->name) . "(JSC::ExecState*, JSC::JSValue);\n");
    887887            }
    … …  
    890890
    891891    foreach my $function (@{$dataNode->functions}) {
    892         $numCustomFunctions++ if $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCCustom"};
     892        $numCustomFunctions++ if $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCustom"};
    893893    }
    894894
    … …  
    896896        push(@headerContent, "\n    // Custom functions\n");
    897897        foreach my $function (@{$dataNode->functions}) {
    898             next unless $function->signature->extendedAttributes->{"Custom"} or $function->signature->extendedAttributes->{"JSCCustom"};
     898            next unless $function->signature->extendedAttributes->{"Custom"} or $function->signature->extendedAttributes->{"JSCustom"};
    899899            next if $function->{overloads} && $function->{overloadIndex} != 1;
    900900            my $functionImplementationName = $function->signature->extendedAttributes->{"ImplementationFunction"} || $codeGenerator->WK_lcfirst($function->signature->name);
    … …  
    16961696                }
    16971697
    1698                 if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCCustomGetter"}) {
     1698                if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomGetter"} || $attribute->signature->extendedAttributes->{"JSCustomGetter"}) {
    16991699                    push(@implContent, "    return castedThis->$implGetterFunctionName(exec);\n");
    17001700                } elsif ($attribute->signature->extendedAttributes->{"CheckAccessToNode"}) {
    … …  
    18951895                        }
    18961896
    1897                         if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCCustomSetter"}) {
     1897                        if ($attribute->signature->extendedAttributes->{"Custom"} || $attribute->signature->extendedAttributes->{"JSCustom"} || $attribute->signature->extendedAttributes->{"CustomSetter"} || $attribute->signature->extendedAttributes->{"JSCustomSetter"}) {
    18981898                            push(@implContent, "    static_cast<$className*>(thisObject)->set$implSetterFunctionName(exec, value);\n");
    18991899                        } elsif ($type eq "EventListener") {
    … …  
    20592059            AddIncludesForTypeInImpl($function->signature->type);
    20602060
    2061             my $isCustom = $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCCustom"};
     2061            my $isCustom = $function->signature->extendedAttributes->{"Custom"} || $function->signature->extendedAttributes->{"JSCustom"};
    20622062            my $isOverloaded = $function->{overloads} && @{$function->{overloads}} > 1;
    20632063

  • trunk/Source/WebCore/css/CSSStyleDeclaration.idl

    r106737 r106773  
    3535
    3636        [ConvertNullStringTo=Null] DOMString          getPropertyValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
    37         [JSCCustom] CSSValue           getPropertyCSSValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
     37        [JSCustom] CSSValue           getPropertyCSSValue(in [Optional=CallWithDefaultValue] DOMString propertyName);
    3838        [ConvertNullStringTo=Null] DOMString          removeProperty(in [Optional=CallWithDefaultValue] DOMString propertyName)
    3939            raises(DOMException);

  • trunk/Source/WebCore/html/HTMLDocument.idl

    r106640 r106773  
    2424        HasOverridingNameGetter
    2525    ] HTMLDocument : Document {
    26         [JSCCustom, V8Custom] void open();
     26        [JSCustom, V8Custom] void open();
    2727        void close();
    2828        [Custom] void write(in [Optional=CallWithDefaultValue] DOMString text);

  • trunk/Source/WebCore/html/canvas/DataView.idl

    r106737 r106773  
    5151
    5252        // Use custom code to handle NaN case for JSC.
    53         [JSCCustom, StrictTypeChecking] float getFloat32(in unsigned long byteOffset, in [Optional] boolean littleEndian)
     53        [JSCustom, StrictTypeChecking] float getFloat32(in unsigned long byteOffset, in [Optional] boolean littleEndian)
    5454            raises (DOMException);
    55         [JSCCustom, StrictTypeChecking] double getFloat64(in unsigned long byteOffset, in [Optional] boolean littleEndian)
     55        [JSCustom, StrictTypeChecking] double getFloat64(in unsigned long byteOffset, in [Optional] boolean littleEndian)
    5656            raises (DOMException);
    5757

  • trunk/Source/WebCore/page/DOMWindow.idl

    r106737 r106773  
    4545        // DOM Level 0
    4646        attribute [Replaceable] Screen screen;
    47         attribute [Replaceable, DoNotCheckDomainSecurityOnGet, JSCCustomGetter] History history;
     47        attribute [Replaceable, DoNotCheckDomainSecurityOnGet, JSCustomGetter] History history;
    4848        attribute [Replaceable] BarInfo locationbar;
    4949        attribute [Replaceable] BarInfo menubar;
    … …  
    5555        attribute [Replaceable] Navigator clientInformation;
    5656        readonly attribute Crypto crypto;
    57         attribute [DoNotCheckDomainSecurity, JSCCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
     57        attribute [DoNotCheckDomainSecurity, JSCustom, V8CustomSetter, V8Unforgeable, CPPCustom] Location location;
    5858
    5959        attribute [Replaceable, CustomGetter, V8CustomSetter] Event event;
    … …  
    473473        attribute HTMLUnknownElementConstructor HTMLUnknownElement;
    474474
    475         attribute [JSCCustomGetter, CustomConstructor] HTMLImageElementConstructorConstructor Image; // Usable with new operator
    476         attribute [JSCCustomGetter] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
     475        attribute [JSCustomGetter, CustomConstructor] HTMLImageElementConstructorConstructor Image; // Usable with new operator
     476        attribute [JSCustomGetter] HTMLOptionElementConstructorConstructor Option; // Usable with new operator
    477477
    478478        attribute CanvasPatternConstructor CanvasPattern;
    … …  
    580580
    581581#if defined(ENABLE_SHARED_WORKERS) && ENABLE_SHARED_WORKERS
    582         attribute [JSCCustomGetter, V8EnabledAtRuntime] SharedWorkerConstructor SharedWorker; // Usable with the new operator
     582        attribute [JSCustomGetter, V8EnabledAtRuntime] SharedWorkerConstructor SharedWorker; // Usable with the new operator
    583583#endif
    584584
    … …  
    603603        attribute StorageConstructor Storage;
    604604
    605         attribute [JSCCustomGetter, Conditional=VIDEO, V8EnabledAtRuntime] HTMLAudioElementConstructorConstructor Audio; // Usable with the new operator
     605        attribute [JSCustomGetter, Conditional=VIDEO, V8EnabledAtRuntime] HTMLAudioElementConstructorConstructor Audio; // Usable with the new operator
    606606        attribute [Conditional=VIDEO, V8EnabledAtRuntime] HTMLAudioElementConstructor HTMLAudioElement;
    607607        attribute [Conditional=VIDEO, V8EnabledAtRuntime] HTMLMediaElementConstructor HTMLMediaElement;

  • trunk/Source/WebCore/page/MemoryInfo.idl

    r89269 r106773  
    3737        readonly attribute unsigned long totalJSHeapSize;
    3838        readonly attribute unsigned long usedJSHeapSize;
    39         readonly attribute [JSCCustomGetter] unsigned long jsHeapSizeLimit;
     39        readonly attribute [JSCustomGetter] unsigned long jsHeapSizeLimit;
    4040
    4141    };

  • trunk/Source/WebCore/webaudio/ConvolverNode.idl

    r106737 r106773  
    2929        JSGenerateToJS
    3030    ] ConvolverNode : AudioNode {
    31         attribute [JSCCustomSetter] AudioBuffer buffer;
     31        attribute [JSCustomSetter] AudioBuffer buffer;
    3232        attribute boolean normalize;
    3333    };

  • trunk/Source/WebCore/webaudio/DOMWindowWebAudio.idl

    r106666 r106773  
    2525    ] DOMWindowWebAudio {
    2626#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
    27         attribute [JSCCustomGetter, V8EnabledAtRuntime] AudioContextConstructor webkitAudioContext;
     27        attribute [JSCustomGetter, V8EnabledAtRuntime] AudioContextConstructor webkitAudioContext;
    2828        attribute AudioPannerNodeConstructor webkitAudioPannerNode;
    2929        attribute AudioProcessingEventConstructor AudioProcessingEvent;

  • trunk/Source/WebCore/webaudio/WaveShaperNode.idl

    r106737 r106773  
    2828        JSGenerateToJS
    2929    ] WaveShaperNode : AudioNode {
    30         attribute [JSCCustomSetter] Float32Array curve;
     30        attribute [JSCustomSetter] Float32Array curve;
    3131    };
    3232}

  • trunk/Source/WebCore/websockets/DOMWindowWebSocket.idl

    r106666 r106773  
    3737#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
    3838        attribute CloseEventConstructor CloseEvent;
    39         attribute [JSCCustomGetter, V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
     39        attribute [JSCustomGetter, V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
    4040#endif
    4141    };

  • trunk/Source/WebCore/workers/WorkerContext.idl

    r106737 r106773  
    8787
    8888#if ENABLE_CHANNEL_MESSAGING
    89         attribute [JSCCustomGetter] MessageChannelConstructor MessageChannel;
     89        attribute [JSCustomGetter] MessageChannelConstructor MessageChannel;
    9090#endif
    91         attribute [JSCCustomGetter] EventSourceConstructor EventSource;
    92         attribute [JSCCustomGetter] XMLHttpRequestConstructor XMLHttpRequest;
     91        attribute [JSCustomGetter] EventSourceConstructor EventSource;
     92        attribute [JSCustomGetter] XMLHttpRequestConstructor XMLHttpRequest;
    9393#if defined(ENABLE_WEB_SOCKETS) && ENABLE_WEB_SOCKETS
    94         attribute [JSCCustomGetter,V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
     94        attribute [JSCustomGetter,V8EnabledAtRuntime] WebSocketConstructor WebSocket; // Usable with the new operator
    9595#endif
    9696#endif
Note: See TracChangeset for help on using the changeset viewer.