Changeset 106774 in webkit


Ignore:
Timestamp:
Feb 5, 2012 9:55:10 PM (12 years ago)
Author:
abarth@webkit.org
Message:

xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=77849

Reviewed by Kentaro Hara.

This test doesn't seem to be sequenced correctly w.r.t. the load events
of the various frames involved. This patch re-orders some of the
triggers in the hopes of making the test no longer flaky.

  • http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/test_expectations.txt:
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r106771 r106774  
     12012-02-05  Adam Barth  <abarth@webkit.org>
     2
     3        xss-DENIED-from-data-url-in-foreign-domain-subframe.html is flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=77849
     5
     6        Reviewed by Kentaro Hara.
     7
     8        This test doesn't seem to be sequenced correctly w.r.t. the load events
     9        of the various frames involved.  This patch re-orders some of the
     10        triggers in the hopes of making the test no longer flaky.
     11
     12        * http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html:
     13        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
     14        * http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html:
     15        * platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
     16        * platform/chromium/test_expectations.txt:
     17
    1182012-02-05  Abhishek Arya  <inferno@chromium.org>
    219

  • trunk/LayoutTests/http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html

    r28995 r106774  
    11<html>
    22<body>
    3     <p>Inner iframe on a foreign domain.</p>
    4     <iframe id="aFrame"></iframe>
    5     <script>
     3<p>Inner iframe on a foreign domain.</p>
     4<iframe id="aFrame"></iframe>
     5<script>
     6    window.onload = function() {
    67        var url = "data:text/html,<html>"
    78            + "<head>"
    … …  
    2829        var frame = document.getElementById('aFrame');
    2930        frame.src = url;
    30     </script>
     31    };
     32</script>
    3133</body>
    3234</html>

  • trunk/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt

    r104803 r106774  
    44The scenario for this test is that you have an iframe with content from a foreign domain. In that foreign content is an iframe which loads a data: URL. This tests that the data: URL loaded iframe does not have access to the main frame using top.document.
    55
     6Pass: Cross frame access from a data: URL on a different domain was denied.
    67
    7 Pass: Cross frame access from a data: URL on a different domain was denied.
     8
    89
    910--------

  • trunk/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html

    r28995 r106774  
    11<html>
    22<head>
    3     <script>
    4         window.onload = function()
    5         {
    6             if (window.layoutTestController) {
    7                 layoutTestController.dumpAsText();
    8                 layoutTestController.dumpChildFramesAsText();
    9                 layoutTestController.waitUntilDone();
    10             }
    11         }
    12     </script>
     3<script>
     4if (window.layoutTestController) {
     5    layoutTestController.dumpAsText();
     6    layoutTestController.dumpChildFramesAsText();
     7    layoutTestController.waitUntilDone();
     8}
     9</script>
    1310</head>
    1411<body>
    … …  
    1613        is an iframe which loads a data: URL.  This tests that the data: URL loaded iframe does not have access
    1714        to the main frame using top.document.</p>
     15    <p id='accessMe'>Pass: Cross frame access from a data: URL on a different domain was denied.</p>
    1816    <iframe id='aFrame' src="http://localhost:8000/security/dataURL/resources/foreign-domain-data-url-accessor-iframe.html" style="width: 400px; height:200px;"></iframe>
    19     <p id='accessMe'>Pass: Cross frame access from a data: URL on a different domain was denied.</p>
    2017</body>
    2118</html>

  • trunk/LayoutTests/platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt

    r104803 r106774  
    44The scenario for this test is that you have an iframe with content from a foreign domain. In that foreign content is an iframe which loads a data: URL. This tests that the data: URL loaded iframe does not have access to the main frame using top.document.
    55
     6Pass: Cross frame access from a data: URL on a different domain was denied.
    67
    7 Pass: Cross frame access from a data: URL on a different domain was denied.
     8
    89
    910--------

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r106765 r106774  
    773773BUGCR31342 WIN RELEASE : security/block-test-no-port.html = PASS TEXT
    774774
    775 BUGCR9798 RELEASE : http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html = PASS TIMEOUT
    776775BUGCR26042 : http/tests/security/mixedContent/insecure-plugin-in-iframe.html = PASS TEXT
    777776BUGWK65567 DEBUG : http/tests/security/mixedContent/insecure-script-in-iframe.html = PASS TEXT
    … …  
    785784BUGWK70298 : http/tests/security/xssAuditor/cookie-injection.html = TEXT PASS
    786785BUGCR24182 WIN RELEASE : http/tests/security/cross-origin-css.html = PASS TIMEOUT
     786
     787// Hopefully fixed flakiness (need to verify with dashboard).
     788BUGCR9798 RELEASE : http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe.html = PASS TIMEOUT
    787789
    788790// -----------------------------------------------------------------
Note: See TracChangeset for help on using the changeset viewer.